You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/31 23:19:36 UTC

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #6747: Fix notify disassocitaion

masayuki2009 commented on code in PR #6747:
URL: https://github.com/apache/incubator-nuttx/pull/6747#discussion_r934053343


##########
drivers/wireless/gs2200m.c:
##########
@@ -2108,6 +2152,35 @@ static enum pkt_type_e gs2200m_activate_wrx(FAR struct gs2200m_dev_s *dev,
   return gs2200m_send_cmd2(dev, cmd);
 }
 
+/****************************************************************************
+ * Name: gs2200m_powersave_wrx
+ * NOTE: See 9.1.1 Active Radio Receive
+ ****************************************************************************/
+
+static enum pkt_type_e gs2200m_powersave_wrx(FAR struct gs2200m_dev_s *dev,
+                                            uint8_t on)
+{
+  char cmd[30];
+
+  snprintf(cmd, sizeof(cmd), "AT+WRXPS=%d\r\n", on);
+  return gs2200m_send_cmd2(dev, cmd);
+}
+
+/****************************************************************************
+ * Name: gs2200m_syncloss
+ * NOTE: See 5.1.4 Sync loss interval
+ ****************************************************************************/
+
+static enum pkt_type_e gs2200m_syncloss(FAR struct gs2200m_dev_s *dev,
+                                            int val)
+{
+  char cmd[30];
+
+  printf("Sync interval = %d x 100ms\n", val);

Review Comment:
   @takayoshi-k 
   printf() should not be used in driver code.
   Please replace it with wlinfo().
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org