[jira] [Commented] (ZOOKEEPER-1913) Invalid manifest files due to bogus revision property value

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974498#comment-13974498 ] 

Hadoop QA commented on ZOOKEEPER-1913:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12640884/ZOOKEEPER-1913.patch
  against trunk revision 1588141.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2051//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2051//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2051//console

This message is automatically generated.

> Invalid manifest files due to bogus revision property value
> -----------------------------------------------------------
>
>                 Key: ZOOKEEPER-1913
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1913
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.5.0
>            Reporter: Raul Gutierrez Segales
>            Assignee: Raul Gutierrez Segales
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1913.patch
>
>
> Without the proposed patch, I get invalid manifests because stderr is added to the revision property. I think this might be something specific to my setup though:
> {noformat}
>     $ java -version
>     Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
>     java version "1.7.0_51"
>     OpenJDK Runtime Environment (fedora-2.4.5.1.fc20-x86_64 u51-b31)
>     OpenJDK 64-Bit Server VM (build 24.51-b03, mixed mode)
> {noformat}
> since it doesn't seem happen with older java/ant combinations.
> Nonetheless, it seems like the right thing is to explicitly ignore stderr.



--
This message was sent by Atlassian JIRA
(v6.2#6252)