[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #55: Support qualified columns in queries

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r624680122



##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -891,6 +898,36 @@ impl Stream for HashJoinStream {
                     }
                     Some(result)
                 }
+                // If maybe_batch is None and num_output_rows is 0, that means right side batch was
+                // empty and has been coalesced to None. Fill right side with Null if preserve_left
+                // is true.
+                None if self.preserve_left && self.num_output_rows == 0 => {

Review comment:
       FYI @houqp I added a more general fix here that deals with all unmatched left rows, so I think you could rebase if that change is merged.
   
   https://github.com/apache/arrow-datafusion/pull/238




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org