You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Alexander Klimetschek (JIRA)" <ji...@apache.org> on 2015/07/15 20:10:05 UTC
[jira] [Comment Edited] (SLING-4882) Shared session usage in Sling
MapEntries causes contention
[ https://issues.apache.org/jira/browse/SLING-4882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628476#comment-14628476 ]
Alexander Klimetschek edited comment on SLING-4882 at 7/15/15 6:09 PM:
-----------------------------------------------------------------------
For reference, here is another stacktrace originating in a custom filter doing an extra resolve(). We have seen multiple concurrent threads executing a vanity path search with the same trace.
It seems unnecessary to do a vanity path search for a request that does not have a vanity path. I agree that having separate sessions is better, but the actual problem is that you need to run queries during requests.
{noformat}
"192.168.193.1 [1436890270925] GET /libs/cq/gui/components/siteadmin/admin/actions/reorder/clientlibs/reorder.min.js HTTP/1.1": awaiting notification on [0x00000005063f5b00]
at sun.misc.Unsafe.park(Native Method)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:867)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1197)
at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:214)
at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:290)
at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate$WarningLock.lock(SessionDelegate.java:744)
at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate$SynchronizedIterator.hasNext(SessionDelegate.java:693)
at org.apache.jackrabbit.oak.jcr.query.PrefetchIterator.hasNext(PrefetchIterator.java:81)
at org.apache.jackrabbit.commons.iterator.RangeIteratorAdapter.hasNext(RangeIteratorAdapter.java:132)
at org.apache.jackrabbit.commons.iterator.RangeIteratorDecorator.hasNext(RangeIteratorDecorator.java:82)
at org.apache.sling.jcr.resource.internal.helper.jcr.JcrNodeResourceIterator.seek(JcrNodeResourceIterator.java:90)
at org.apache.sling.jcr.resource.internal.helper.jcr.JcrNodeResourceIterator.<init>(JcrNodeResourceIterator.java:64)
at org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.findResources(JcrResourceProvider.java:265)
at org.apache.sling.resourceresolver.impl.tree.RootResourceProviderEntry$2.seek(RootResourceProviderEntry.java:148)
at org.apache.sling.resourceresolver.impl.tree.RootResourceProviderEntry$2.<init>(RootResourceProviderEntry.java:134)
at org.apache.sling.resourceresolver.impl.tree.RootResourceProviderEntry.findResources(RootResourceProviderEntry.java:132)
at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.findResources(ResourceResolverImpl.java:668)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.getVanityPaths(MapEntries.java:860)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.getMapEntryList(MapEntries.java:714)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.access$100(MapEntries.java:69)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries$MapEntryIterator.seek(MapEntries.java:1456)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries$MapEntryIterator.<init>(MapEntries.java:1407)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.getResolveMapsIterator(MapEntries.java:694)
at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:249)
at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolve(ResourceResolverImpl.java:192)
at com.day.cq.wcm.core.impl.AuthoringUIModeServiceImpl.isEditor(AuthoringUIModeServiceImpl.java:385)
at com.day.cq.wcm.core.impl.AuthoringUIModeServiceImpl.doFilter(AuthoringUIModeServiceImpl.java:300)
at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60)
{noformat}
was (Author: alexander.klimetschek):
For reference, here is another stacktrace originating in a custom filter doing an extra resolve(). We have seen multiple concurrent threads executing a vanity path search.
It seems unnecessary to do a vanity path search for a request that does not have a vanity path. I agree that having separate sessions is better, but the actual problem is that you need to run queries during requests.
{noformat}
"192.168.193.1 [1436890270925] GET /libs/cq/gui/components/siteadmin/admin/actions/reorder/clientlibs/reorder.min.js HTTP/1.1": awaiting notification on [0x00000005063f5b00]
at sun.misc.Unsafe.park(Native Method)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:867)
at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1197)
at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:214)
at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:290)
at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate$WarningLock.lock(SessionDelegate.java:744)
at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate$SynchronizedIterator.hasNext(SessionDelegate.java:693)
at org.apache.jackrabbit.oak.jcr.query.PrefetchIterator.hasNext(PrefetchIterator.java:81)
at org.apache.jackrabbit.commons.iterator.RangeIteratorAdapter.hasNext(RangeIteratorAdapter.java:132)
at org.apache.jackrabbit.commons.iterator.RangeIteratorDecorator.hasNext(RangeIteratorDecorator.java:82)
at org.apache.sling.jcr.resource.internal.helper.jcr.JcrNodeResourceIterator.seek(JcrNodeResourceIterator.java:90)
at org.apache.sling.jcr.resource.internal.helper.jcr.JcrNodeResourceIterator.<init>(JcrNodeResourceIterator.java:64)
at org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.findResources(JcrResourceProvider.java:265)
at org.apache.sling.resourceresolver.impl.tree.RootResourceProviderEntry$2.seek(RootResourceProviderEntry.java:148)
at org.apache.sling.resourceresolver.impl.tree.RootResourceProviderEntry$2.<init>(RootResourceProviderEntry.java:134)
at org.apache.sling.resourceresolver.impl.tree.RootResourceProviderEntry.findResources(RootResourceProviderEntry.java:132)
at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.findResources(ResourceResolverImpl.java:668)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.getVanityPaths(MapEntries.java:860)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.getMapEntryList(MapEntries.java:714)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.access$100(MapEntries.java:69)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries$MapEntryIterator.seek(MapEntries.java:1456)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries$MapEntryIterator.<init>(MapEntries.java:1407)
at org.apache.sling.resourceresolver.impl.mapping.MapEntries.getResolveMapsIterator(MapEntries.java:694)
at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolveInternal(ResourceResolverImpl.java:249)
at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.resolve(ResourceResolverImpl.java:192)
at com.day.cq.wcm.core.impl.AuthoringUIModeServiceImpl.isEditor(AuthoringUIModeServiceImpl.java:385)
at com.day.cq.wcm.core.impl.AuthoringUIModeServiceImpl.doFilter(AuthoringUIModeServiceImpl.java:300)
at org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:60)
{noformat}
> Shared session usage in Sling MapEntries causes contention
> ----------------------------------------------------------
>
> Key: SLING-4882
> URL: https://issues.apache.org/jira/browse/SLING-4882
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.2.8
>
> Attachments: SLING-4882-patch.txt, SLING-4882-patchv2.txt
>
>
> {code:none}
> "pool-7-thread-103" prio=10 tid=0x00007fede006c000 nid=0x6db8 waiting on condition [0x00007fecdbb7a000]
> java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0x00000005063f5b00> (a java.util.concurrent.locks.ReentrantLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
> at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
> at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:867)
> at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1197)
> at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:214)
> at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:290)
> at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate$WarningLock.lock(SessionDelegate.java:744)
> at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate$WarningLock.lock(SessionDelegate.java:775)
> at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:271)
> at org.apache.jackrabbit.oak.jcr.session.SessionImpl.perform(SessionImpl.java:127)
> at org.apache.jackrabbit.oak.jcr.session.SessionImpl.refresh(SessionImpl.java:430)
> at sun.reflect.GeneratedMethodAccessor46.invoke(Unknown Source)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at org.apache.sling.jcr.base.SessionProxyHandler$SessionProxyInvocationHandler.invoke(SessionProxyHandler.java:113)
> at com.sun.proxy.$Proxy7.refresh(Unknown Source)
> at org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.refresh(JcrResourceProvider.java:545)
> at org.apache.sling.resourceresolver.impl.helper.ResourceResolverContext.refresh(ResourceResolverContext.java:192)
> at org.apache.sling.resourceresolver.impl.ResourceResolverImpl.refresh(ResourceResolverImpl.java:1186)
> at org.apache.sling.resourceresolver.impl.mapping.MapEntries.doAddAttributes(MapEntries.java:321)
> at org.apache.sling.resourceresolver.impl.mapping.MapEntries.handleEvent(MapEntries.java:776)
> at org.apache.felix.eventadmin.impl.handler.EventHandlerProxy.sendEvent(EventHandlerProxy.java:412)
> at org.apache.felix.eventadmin.impl.tasks.SyncDeliverTasks.execute(SyncDeliverTasks.java:118)
> at org.apache.felix.eventadmin.impl.handler.EventAdminImpl.sendEvent(EventAdminImpl.java:114)
> at org.apache.felix.eventadmin.impl.security.EventAdminSecurityDecorator.sendEvent(EventAdminSecurityDecorator.java:96)
> at org.apache.sling.jcr.resource.internal.OakResourceListener.sendOsgiEvent(OakResourceListener.java:243)
> at org.apache.sling.jcr.resource.internal.OakResourceListener.added(OakResourceListener.java:109)
> at org.apache.jackrabbit.oak.plugins.observation.NodeObserver$NodeEventHandler.leave(NodeObserver.java:209)
> at org.apache.jackrabbit.oak.plugins.observation.FilteredHandler.leave(FilteredHandler.java:51)
> at org.apache.jackrabbit.oak.plugins.observation.EventGenerator$Continuation.run(EventGenerator.java:182)
> at org.apache.jackrabbit.oak.plugins.observation.EventGenerator.generate(EventGenerator.java:124)
> at org.apache.jackrabbit.oak.plugins.observation.NodeObserver.contentChanged(NodeObserver.java:163)
> at org.apache.jackrabbit.oak.spi.commit.BackgroundObserver$1$1.call(BackgroundObserver.java:124)
> at org.apache.jackrabbit.oak.spi.commit.BackgroundObserver$1$1.call(BackgroundObserver.java:118)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)