You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by Aitozi <gi...@git.apache.org> on 2018/06/14 06:56:15 UTC

[GitHub] flink pull request #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQ...

GitHub user Aitozi opened a pull request:

    https://github.com/apache/flink/pull/6162

    [FLINK-9579][CEP]Remove unneeded clear on elementQueueState

    ## What is the purpose of the change
    
    Remove unneeded clear on elementQueueState， when soretedTimestamp is empty, the elements in elementQueueState are all removed, so don't need to clear again to waste time on RocksDB operation.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Aitozi/flink remove-clear

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6162
    
----
commit 62a1a506cf8dab263a247d81fa7092eaa0743624
Author: minwenjun <mi...@...>
Date:   2018-06-14T06:20:42Z

    [FLINK-9579][CEP]Remove unneeded clear on elementQueueState

----


---

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Posted by Aitozi <gi...@git.apache.org>.

Github user Aitozi commented on the issue:

    https://github.com/apache/flink/pull/6162
  
    Is this OK? @dawidwys 


---

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Posted by dawidwys <gi...@git.apache.org>.

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/6162
  
    I think this is a valid change. LGTM
    
    Thanks for the contribution!


---

[GitHub] flink pull request #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6162


---

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Posted by dawidwys <gi...@git.apache.org>.

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/6162
  
    Yes, will merge shortly.


---

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Posted by Aitozi <gi...@git.apache.org>.

Github user Aitozi commented on the issue:

    https://github.com/apache/flink/pull/6162
  
    Thanks for your review , remove the same block in `onProcessingTime`.


---

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Posted by dawidwys <gi...@git.apache.org>.

Github user dawidwys commented on the issue:

    https://github.com/apache/flink/pull/6162
  
    Actually. Could you also remove the same block from `onProcessingTime`


---