[GitHub] [cloudstack] mlsorensen commented on a diff in pull request #6522: Volume encryption feature

[GitBox <gi...@apache.org>]

mlsorensen commented on code in PR #6522:
URL: https://github.com/apache/cloudstack/pull/6522#discussion_r938967766


##########
core/src/main/java/org/apache/cloudstack/storage/to/VolumeObjectTO.java:
##########
@@ -357,4 +366,22 @@ public String getvSphereStoragePolicyId() {
     public void setvSphereStoragePolicyId(String vSphereStoragePolicyId) {
         this.vSphereStoragePolicyId = vSphereStoragePolicyId;
     }
+
+    public String getEncryptFormat() { return encryptFormat; }
+
+    public void setEncryptFormat(String encryptFormat) { this.encryptFormat = encryptFormat; }
+
+    public byte[] getPassphrase() { return passphrase; }
+
+    public void setPassphrase(byte[] passphrase) { this.passphrase = passphrase; }

Review Comment:
   Cool, I'll review those and change them. We should probably add an exception for single line blocks, seems cleaner, but that's an opinion to discuss another day :-) Will get on this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org