[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2895: add session option 'datafusion.explain.logical_plan'. when set to true, the explain statement will only print logical plans.

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2895:
URL: https://github.com/apache/arrow-datafusion/pull/2895#discussion_r919949364


##########
datafusion/core/src/config.rs:
##########
@@ -27,6 +27,9 @@ use std::env;
 /// Configuration option "datafusion.optimizer.filter_null_join_keys"
 pub const OPT_FILTER_NULL_JOIN_KEYS: &str = "datafusion.optimizer.filter_null_join_keys";
 
+/// Configuration option "datafusion.explain.logical_plan"

Review Comment:
   ```suggestion
   /// Configuration option "datafusion.explain.logical_plan_only"
   ```
   
   Maybe we could call it `datafusion.explain.logical_plan_only` to be consistent with the internal implementation and be more self describing
   
   Another way to encode this might be "datafusion.explain.include_physical_plan", defaulted to true. That way we could also encode a "datafusion.explain.include_logical_plan" if people ever wanted only the physical plan
   
   This way works too.  problem with this way, however



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org