You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/04 05:28:42 UTC

[GitHub] [spark] kbendick opened a new pull request #30244: [SPARK-33282] Migrate from dead probot autolabeler to GitHub labeler action

kbendick opened a new pull request #30244:
URL: https://github.com/apache/spark/pull/30244

### What changes were proposed in this pull request?

This PR removes the old Probot Autolabeler labeling configuration, as the probot autolabeler has been deprecated. I've updated the configs in Iceberg and in Avro, and we also need to update here. This PR adds in an additional workflow for labeling PRs and migrates the old probot config to the new format. Unfortunately, because certain features have not been released upstream, we will not get the _exact_ behavior as before. I have documented where that is and what changes are neeeded, and in the associated ticket I've also discussed other options and why I think this is the best way to go. Definitely a follow up ticket is needed to get the original behavior back in these few cases, but PRs have not been labeled for almost a month and so it's probably best to get it right 95% of the time and occasionally have some UI related PRs labeled as `CORE` while the issue is resolved upstream and/or further investigated.

### Why are the changes needed?

The probot autolabeler is dead and will not be maintained going forward. This has been confirmed with github user [at]mithro in an issue in their repository.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

By merging into my personal fork and then running a large number of tests.

Unfortunately, I've overwritten my fork with the apache repo in order to create a proper PR. However, I've also added the config for the same thing in the Iceberg repo as well as the Avro repo. I can work on adding tests for this, but I'm pretty swamped this week and the next so either somebody else would have to take the lead on that, we'd have to wait, or we can just inspect it, merge it, and then observe what happens as PRs come in. I personally vote for the latter but thats probably because this is the third one of these I've done in the `apache` sphere and I admittedly won't have much time to work on it for another week or so, but I'm happy to make tickets and to let anybody who would like to take the reins.

I've also discovered that we're likely not killing github actions that run (like large tests etc) when users push to their PR. In order to save time / capacity on the runners, we should add an action in each workflow that cancels old runs when a `push` action occurs on a PR. This will likely make waiting for test runners much faster, especially if added to all of the workflows in the Apache account (as github action API limits are set at the account level).

Admittedly, the fact that the "old" workflow runs weren't cancelled could admittedly be because of the fact that I was working in a fork, but given that there are explicit actions to be added to the start of workflows to cancel old PR workflows and given that we don't have them configured indicates to me that likely this is the case in this repo (and in most `apache` repos as well).

The last Apache repo to still have the probot autolabeler in it is Beam, at which point we can have Gavin from Infra remove the permissions for the probot autolabeler entirely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org