patch submission

[Ted Yu <yu...@gmail.com>]

A common question among HBase contributors, especially hadoop
contributors/committers, is related to the 'Submit patch' button.
Clicking the button wouldn't trigger build on Jenkins. The setup here is
different from that for hadoop.

My understanding is that clicking the button means the author is confident
that his/her patch is in a reviewable state.
The patches attached to JIRAs before 'Submit patch' button is clicked can be
regarded as preview version.

Cheers

Re: patch submission

[Doug Meil <do...@explorysmedical.com>]

Yep, that's the way I wrote it up in the book.

http://hbase.apache.org/book.html#submitting.patches





On 8/21/11 3:16 PM, "Andrew Purtell" <ap...@apache.org> wrote:

>> My understanding is that clicking the button means the author is
>>confident
>> that his/her patch is in a reviewable state.
>> The patches attached to JIRAs before 'Submit patch' button is clicked
>> can be regarded as preview version.
>
>
>This is correct according to my understanding as well.
> 
>Best regards,
>
>
>   - Andy
>
>Problems worthy of attack prove their worth by hitting back. - Piet Hein
>(via Tom White)
>
>
>----- Original Message -----
>> From: Ted Yu <yu...@gmail.com>
>> To: dev@hbase.apache.org
>> Cc: brock@cloudera.com; Doug Meil <do...@explorysmedical.com>
>> Sent: Sunday, August 21, 2011 12:09 PM
>> Subject: patch submission
>> 
>> A common question among HBase contributors, especially hadoop
>> contributors/committers, is related to the 'Submit patch' button.
>> Clicking the button wouldn't trigger build on Jenkins. The setup here is
>> different from that for hadoop.
>> 
>> My understanding is that clicking the button means the author is
>>confident
>> that his/her patch is in a reviewable state.
>> The patches attached to JIRAs before 'Submit patch' button is clicked
>> can be regarded as preview version.
>> 
>> Cheers
>>

Re: patch submission

[Andrew Purtell <ap...@apache.org>]

> My understanding is that clicking the button means the author is confident
> that his/her patch is in a reviewable state.
> The patches attached to JIRAs before 'Submit patch' button is clicked 
> can be regarded as preview version.


This is correct according to my understanding as well.
 
Best regards,


   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)


----- Original Message -----
> From: Ted Yu <yu...@gmail.com>
> To: dev@hbase.apache.org
> Cc: brock@cloudera.com; Doug Meil <do...@explorysmedical.com>
> Sent: Sunday, August 21, 2011 12:09 PM
> Subject: patch submission
> 
> A common question among HBase contributors, especially hadoop
> contributors/committers, is related to the 'Submit patch' button.
> Clicking the button wouldn't trigger build on Jenkins. The setup here is
> different from that for hadoop.
> 
> My understanding is that clicking the button means the author is confident
> that his/her patch is in a reviewable state.
> The patches attached to JIRAs before 'Submit patch' button is clicked 
> can be regarded as preview version.
> 
> Cheers
>