You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "liaorui (via GitHub)" <gi...@apache.org> on 2023/06/29 09:50:19 UTC
[GitHub] [inlong] liaorui opened a new pull request, #8373: [INLONG-8372][Sort]MySQL connector supports uploading flink job delay metrics
liaorui opened a new pull request, #8373:
URL: https://github.com/apache/inlong/pull/8373
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #XYZ
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
Now mysql cdc connector has two [delay metrics](https://github.com/ververica/flink-cdc-connectors/blob/ba5fcbc97b46bbe57a2937622afa1562885beed8/flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/metrics/MySqlSourceReaderMetrics.java#L52C36-L52C36): `currentFetchEventTimeLag` and `currentEmitEventTimeLag`.
We could know if mysql cdc connector can follow MySQL binlog in time by this two metrics. The higher values ,the delay is severer.
Inlong metrics don't contain these now.
### Modifications
*Describe the modifications you've done.*
1. `MetricData` has `registerGauge` method which is used for registering a gauge metric.
2. `SourceMetricData` has two new `Gauge` parameters: `currentFetchEventTimeLag` and `currentEmitEventTimeLag`. It also has two long parameters `fetchDelay` and `emitDelay` which is set by every source connector. `currentFetchEventTimeLag` and `currentEmitEventTimeLag` read `fetchDelay` and `emitDelay` value and upload them to Inlong metric system.
3. `SourceMetricData` and `SourceTableMetricData` classes have some new overriding methods which have two long parameters. Every source connector could update their delay metrics by invoking these methods.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #8373: [INLONG-8372][Sort] MySQL connector supports uploading flink job delay metrics
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #8373:
URL: https://github.com/apache/inlong/pull/8373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org