[jira] [Commented] (LUCENE-8293) Ensure only hard deletes are carried over in a merge

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462266#comment-16462266 ] 

Michael McCandless commented on LUCENE-8293:
--------------------------------------------

+1, tricky ... we were previously just asking the merged reader for its live docs, but this included hard and soft deletes, so you fixed it to explicitly pull only hard deletes from the {{RLD}}.

I like how you factored out a method from that scary {{commitMergedDeletesAndUpdates}} method.

> Ensure only hard deletes are carried over in a merge
> ----------------------------------------------------
>
>                 Key: LUCENE-8293
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8293
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8293.patch
>
>
> Today we carry over hard deletes based on the SegmentReaders liveDocs.
>     This is not correct if soft-deletes are used especially with rentention
>     policies. If a soft delete is added while a segment is merged the document
>     might end up hard deleted in the target segment. This isn't necessarily a
>     correctness issue but causes unnecessary writes of hard-deletes. The biggest
>     issue here is that we assert that previously deleted documents are still deleted
>     in the live-docs we apply and that might be violated by the retention policy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org