You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Apekshit Sharma <ap...@cloudera.com> on 2016/10/10 21:55:15 UTC

Should we remove Mob Sweeper MR job

From what i understand, it was part of initial implementation of MOB but
was later replaced by DefaultMobStoreCompactor and ExpiredMobFileCleaner.
Let's remove this 1500+ lines tool if it's redundant, because it's
unnecessary maintainence. I stumbled across it when i was trying to replace
zk table locks with procedure locks.

-- Appy

Re: Should we remove Mob Sweeper MR job

Posted by Jonathan Hsieh <jo...@cloudera.com>.
As a data point, we have several more months of users using the intrinsic
mob compaction and have had no need for the MR based tool.   Since this
code hasn't been released with an apache hbase release, I'd be fine if it
were removed unless any users have any concerns with its removal.

Jon.

On Mon, Oct 10, 2016 at 2:55 PM, Apekshit Sharma <ap...@cloudera.com> wrote:

> From what i understand, it was part of initial implementation of MOB but
> was later replaced by DefaultMobStoreCompactor and ExpiredMobFileCleaner.
> Let's remove this 1500+ lines tool if it's redundant, because it's
> unnecessary maintainence. I stumbled across it when i was trying to replace
> zk table locks with procedure locks.
>
> -- Appy
>



-- 
// Jonathan Hsieh (shay)
// HBase Tech Lead, Software Engineer, Cloudera
// jon@cloudera.com // @jmhsieh

RE: Should we remove Mob Sweeper MR job

Posted by "Du, Jingcheng" <ji...@intel.com>.
It would be fine to remove it.

Regards,
Jingcheng

-----Original Message-----
From: Ted Yu [mailto:yuzhihong@gmail.com] 
Sent: Tuesday, October 11, 2016 6:03 AM
To: dev@hbase.apache.org
Subject: Re: Should we remove Mob Sweeper MR job

Seems good cleanup to do.

On Mon, Oct 10, 2016 at 2:55 PM, Apekshit Sharma <ap...@cloudera.com> wrote:

> From what i understand, it was part of initial implementation of MOB 
> but was later replaced by DefaultMobStoreCompactor and ExpiredMobFileCleaner.
> Let's remove this 1500+ lines tool if it's redundant, because it's 
> unnecessary maintainence. I stumbled across it when i was trying to 
> replace zk table locks with procedure locks.
>
> -- Appy
>

Re: Should we remove Mob Sweeper MR job

Posted by Ted Yu <yu...@gmail.com>.
Seems good cleanup to do.

On Mon, Oct 10, 2016 at 2:55 PM, Apekshit Sharma <ap...@cloudera.com> wrote:

> From what i understand, it was part of initial implementation of MOB but
> was later replaced by DefaultMobStoreCompactor and ExpiredMobFileCleaner.
> Let's remove this 1500+ lines tool if it's redundant, because it's
> unnecessary maintainence. I stumbled across it when i was trying to replace
> zk table locks with procedure locks.
>
> -- Appy
>