[GitHub] [spark] Hisoka-X commented on a diff in pull request #40326: [SPARK-42708] [Docs] Improve doc about protobuf java file can't be indexed.

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #40326:
URL: https://github.com/apache/spark/pull/40326#discussion_r1130922230


##########
connector/protobuf/README.md:
##########
@@ -34,3 +34,17 @@ export SPARK_PROTOC_EXEC_PATH=/path-to-protoc-exe
 
 The user-defined `protoc` binary files can be produced in the user's compilation environment by source code compilation, 
 for compilation steps, please refer to [protobuf](https://github.com/protocolbuffers/protobuf).
+
+### Work with IDE

Review Comment:
   > On the other hand, there are many modules that use protobuf, such as core (in fact, the StoreTypes generated in the core module have exceeded the default limit of IntelliJ), connect-common, so if we need to add this one, should put it in a more general place instead of in protobuf module.
   
   Yes, the reason why I want to add this because I find `StoreTypes` can't be indexed by default. At first I want add this in to core's README.md (but core doesn't have one), so I think add this in protobuf module not bad choice. If put this into core's README.md, I would create new README.md in core module and only describe some protobuf problems. it's weird.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org