You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/21 17:46:52 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #22071: Bug-fix GCSToS3Operator

potiuk commented on a change in pull request #22071:
URL: https://github.com/apache/airflow/pull/22071#discussion_r831385579



##########
File path: airflow/providers/amazon/aws/transfers/gcs_to_s3.py
##########
@@ -147,6 +152,9 @@ def execute(self, context: 'Context') -> List[str]:
             aws_conn_id=self.dest_aws_conn_id, verify=self.dest_verify, extra_args=self.dest_s3_extra_args
         )
 
+        if not self.keep_directory_structure and self.prefix:
+            self.dest_s3_key = os.path.join(self.dest_s3_key, self.prefix)

Review comment:
       Feel free to make PR. Airflow only works on POSIX (for multiple reasons) but you are right it would be beter to even hardcode "/'".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org