You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Yun Tang (Jira)" <ji...@apache.org> on 2022/04/01 02:42:00 UTC

[jira] [Commented] (FLINK-14998) Remove FileUtils#deletePathIfEmpty

    [ https://issues.apache.org/jira/browse/FLINK-14998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515679#comment-17515679 ] 

Yun Tang commented on FLINK-14998:
----------------------------------

[~jay li], you can refer to https://flink.apache.org/contributing/contribute-code.html for more details to know how to create a PR. For the next question, I think it's clear to see and we can discuss in the review of PR.

> Remove FileUtils#deletePathIfEmpty
> ----------------------------------
>
>                 Key: FLINK-14998
>                 URL: https://issues.apache.org/jira/browse/FLINK-14998
>             Project: Flink
>          Issue Type: Bug
>          Components: FileSystems
>            Reporter: Yun Tang
>            Assignee: jay li
>            Priority: Minor
>              Labels: auto-deprioritized-major, starter
>             Fix For: 1.16.0
>
>
> With the lesson learned from FLINK-7266, and the refactor of FLINK-8540, method of  {{FileUtils#deletePathIfEmpty}} has been totally useless in Flink production code. From my point of view, it's not wise to provide a method with already known high-risk defect in Flink official code. I suggest to remove this part of code.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)