You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/04/14 01:20:20 UTC

Review Request 58444: Log Feeder fill cluster name if it is not set

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/
-----------------------------------------------------------

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20766
    https://issues.apache.org/jira/browse/AMBARI-20766


Repository: ambari


Description
-------

If for some reason there is no cluster set for a log entry, set it to the actual cluster.


Diffs
-----

  ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 9a9f973 


Diff: https://reviews.apache.org/r/58444/diff/1/


Testing
-------

tested on local cluster


Thanks,

Miklos Gergely


Re: Review Request 58444: Log Feeder fill cluster name if it is not set

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/#review172669
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On April 21, 2017, 3:28 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58444/
> -----------------------------------------------------------
> 
> (Updated April 21, 2017, 3:28 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20766
>     https://issues.apache.org/jira/browse/AMBARI-20766
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If for some reason there is no cluster set for a log entry, set it to the actual cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 9a9f973 
> 
> 
> Diff: https://reviews.apache.org/r/58444/diff/2/
> 
> 
> Testing
> -------
> 
> tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 58444: Log Feeder fill cluster name if it is not set

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/
-----------------------------------------------------------

(Updated April 21, 2017, 3:28 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

Modify the method so it fits branch-2.5 too


Bugs: AMBARI-20766
    https://issues.apache.org/jira/browse/AMBARI-20766


Repository: ambari


Description
-------

If for some reason there is no cluster set for a log entry, set it to the actual cluster.


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 9a9f973 


Diff: https://reviews.apache.org/r/58444/diff/2/

Changes: https://reviews.apache.org/r/58444/diff/1-2/


Testing
-------

tested on local cluster


Thanks,

Miklos Gergely


Re: Review Request 58444: Log Feeder fill cluster name if it is not set

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/#review172522
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On April 14, 2017, 1:20 a.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58444/
> -----------------------------------------------------------
> 
> (Updated April 14, 2017, 1:20 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20766
>     https://issues.apache.org/jira/browse/AMBARI-20766
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If for some reason there is no cluster set for a log entry, set it to the actual cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 9a9f973 
> 
> 
> Diff: https://reviews.apache.org/r/58444/diff/1/
> 
> 
> Testing
> -------
> 
> tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 58444: Log Feeder fill cluster name if it is not set

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58444/#review171997
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On April 14, 2017, 1:20 a.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58444/
> -----------------------------------------------------------
> 
> (Updated April 14, 2017, 1:20 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20766
>     https://issues.apache.org/jira/browse/AMBARI-20766
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If for some reason there is no cluster set for a log entry, set it to the actual cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java 9a9f973 
> 
> 
> Diff: https://reviews.apache.org/r/58444/diff/1/
> 
> 
> Testing
> -------
> 
> tested on local cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>