You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2025/10/30 02:18:18 UTC

(kafka) branch trunk updated: MINOR: Correct javadoc and comment in AbstractFetch#fetchablePartitions (#20790)

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 5c49b48eb07 MINOR: Correct javadoc and comment in AbstractFetch#fetchablePartitions (#20790)
5c49b48eb07 is described below

commit 5c49b48eb0732043400ec1ffb23022ebb3b47085
Author: majialong <ma...@gmail.com>
AuthorDate: Thu Oct 30 10:18:12 2025 +0800

    MINOR: Correct javadoc and comment in AbstractFetch#fetchablePartitions (#20790)
    
    This PR is a minor improvement on the [previous
    PR](https://github.com/apache/kafka/pull/20745), correcting the javadoc
    and comment information.
    
    Reviewers: TaiJuWu <tj...@gmail.com>, Chia-Ping Tsai
     <ch...@gmail.com>
---
 .../org/apache/kafka/clients/consumer/internals/AbstractFetch.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java
index 27f7fce1fab..c20c5bd8cfb 100644
--- a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java
+++ b/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java
@@ -335,7 +335,7 @@ public abstract class AbstractFetch implements Closeable {
     }
 
     /**
-     * Return the set of <em>fetchable</em> partitions, which are the set of partitions to which we are subscribed,
+     * Return the list of <em>fetchable</em> partitions, which are the list of partitions to which we are subscribed,
      * but <em>excluding</em> any partitions for which we still have buffered data. The idea is that since the user
      * has yet to process the data for the partition that has already been fetched, we should not go send for more data
      * until the previously-fetched data has been processed.
@@ -429,7 +429,7 @@ public abstract class AbstractFetch implements Closeable {
         // This is the set of partitions that have buffered data
         Set<TopicPartition> buffered = Collections.unmodifiableSet(fetchBuffer.bufferedPartitions());
 
-        // This is the set of partitions that do not have buffered data
+        // This is the list of partitions that are fetchable and have no buffered data
         List<TopicPartition> unbuffered = fetchablePartitions(buffered);
 
         if (unbuffered.isEmpty()) {