You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 14:06:25 UTC

[GitHub] [airflow] YossiTamari opened a new issue #20632: Add priorityClassName support

YossiTamari opened a new issue #20632:
URL: https://github.com/apache/airflow/issues/20632


   ### Official Helm Chart version
   
   1.2.0
   
   ### Apache Airflow version
   
   2.1.4
   
   ### Kubernetes Version
   
   1.21.2
   
   ### Helm Chart configuration
   
   _No response_
   
   ### Docker Image customisations
   
   _No response_
   
   ### What happened
   
   _No response_
   
   ### What you expected to happen
   
   _No response_
   
   ### How to reproduce
   
   _No response_
   
   ### Anything else
   
   It's currently impossible to assign a `priorityClassName` to the Airflow containers.
   Seems like a very useful feature to ensure that the Airflow infrastructure has higher priority than "regular" pods.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #20632: Add priorityClassName support

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #20632:
URL: https://github.com/apache/airflow/issues/20632#issuecomment-1009280832


   assigned it @subkanthi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham closed issue #20632: Add priorityClassName support

Posted by GitBox <gi...@apache.org>.
jedcunningham closed issue #20632:
URL: https://github.com/apache/airflow/issues/20632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] subkanthi commented on issue #20632: Add priorityClassName support

Posted by GitBox <gi...@apache.org>.
subkanthi commented on issue #20632:
URL: https://github.com/apache/airflow/issues/20632#issuecomment-1006813005


   I can take on this, thoughts on the priorityClasses would be useful.
   Simple proposal would be to define 3 priority classes(high, medium, low) and then assign it to different deployments. Maybe airflow-migration takes high priority.
   
   
   ```apiVersion: scheduling.k8s.io/v1
   kind: PriorityClass
   metadata:
     name: high-priority-nonpreempting
   value: 1000000
   preemptionPolicy: Never
   globalDefault: false
   description: "This priority class will not cause other pods to be preempted."```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] YossiTamari commented on issue #20632: Add priorityClassName support

Posted by GitBox <gi...@apache.org>.
YossiTamari commented on issue #20632:
URL: https://github.com/apache/airflow/issues/20632#issuecomment-1008280001


   Hi @subkanthi, thanks for taking this. My request was only to add support for assigning priorities in values.yaml, not necessarily for creating priorities or assigning them by default (Same thing as [affinity](https://airflow.apache.org/docs/helm-chart/stable/parameters-ref.html#kubernetes), which has a default empty value).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #20632: Add priorityClassName support

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #20632:
URL: https://github.com/apache/airflow/issues/20632#issuecomment-1004114987


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org