[jira] [Commented] (PHOENIX-4066) Unused variable in MutationState.send()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114923#comment-16114923 ] 

Hadoop QA commented on PHOENIX-4066:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12880433/PHOENIX-4066.patch
  against master branch at commit 0bd43f536a13609b35629308c415aebc800d6799.
  ATTACHMENT ID: 12880433

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 54 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterMultiTenantTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryDatabaseMetaDataIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1244//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1244//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1244//console

This message is automatically generated.

> Unused variable in MutationState.send()
> ---------------------------------------
>
>                 Key: PHOENIX-4066
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4066
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.11.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Trivial
>              Labels: beginner
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4066.patch
>
>
> In MutationState#send, we always allocate the following:
> List<TableRef> txTableRefs = Lists.newArrayListWithExpectedSize(mutations.size());
> and if a table's transactional, we populate it:
> txTableRefs.add(origTableRef);`
> but this is never referred to again in either logic or logging, and it's a local variable so we can't be using it elsewhere either. It should be removed or used (and if used, it should only be allocated in the transactional use case.)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)