[GitHub] [spark] Hisoka-X commented on a diff in pull request #41065: [SPARK-43384][SQL] Make `df.show` print a nice string for `MapType`.

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #41065:
URL: https://github.com/apache/spark/pull/41065#discussion_r1186591709


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ToPrettyString.scala:
##########
@@ -45,6 +45,10 @@ case class ToPrettyString(child: Expression, timeZoneId: Option[String] = None)
   override protected def leftBracket: String = "{"
   override protected def rightBracket: String = "}"
 
+  override def kvPairSeparator: String = ":"
+
+  override protected def elementSeparator: String = ","

Review Comment:
   ```suggestion
     override protected def elementSeparator: String = ", "
   ```
   Add space between kv maybe better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org