You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sollhui (via GitHub)" <gi...@apache.org> on 2026/10/23 13:22:48 UTC

[PR] [refactor](fe) Separate filesystem routing validation and fallback hooks [doris]

sollhui opened a new pull request, #69550:
URL: https://github.com/apache/doris/pull/69550

   ### What problem does this PR solve?
   
   Related PR: #68540
   
   Filesystem routing cannot express that a specific provider supersedes a general heuristic match. Invalid provider-owned properties can also disappear when routing selects another provider.
   
   Add two default SPI hooks: `validateProperties()` and `fallbackProviders()`. Apply them consistently to direct creation, primary binding, multi-provider binding, and forced-provider validation. Explicit filesystem flags retain priority, existing provider ordering is preserved, and providers that do not opt in retain their current behavior.
   
   This independent prerequisite is based directly on `master` at `31615e01791`. It contains no GCP provider implementation, SDK dependencies, authentication types, or protocol changes. GCS opts into the hooks in #68540. Review and merge this prerequisite before that feature.
   
   ### Release note
   
   Filesystem plugins can validate owned properties before routing and declare heuristic fallback providers. The filesystem plugin API changes from 1.0 to 2.0; rebuild plugins against the matching host API.
   
   ### Validation
   
   - Passed: FE Core/SPI Checkstyle, parsing of all four changed Java files, and `git diff --check`.
   - Added tests: registration-order independence, explicit selections, multi-provider binding, HDFS fallback preservation, avoiding unnecessary provider probes, and invalid properties owned by an unselected provider.
   - The API surface baseline is updated for exactly the two new methods.
   - Full unit tests remain unexecuted: after restoring the local dependency bundle, the standard runner stopped because installed Thrift 0.16.0 does not match required 0.24.0.
   
   ### Check List (For Author)
   
   - Test: unit coverage included; execution limitations above.
   - Behavior changed: Opt-in validation/fallback routing, with defaults preserving existing providers.
   - Does this need documentation: Yes, filesystem README updated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](fe) Separate filesystem routing validation and fallback hooks [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui closed pull request #69550: [refactor](fe) Separate filesystem routing validation and fallback hooks
URL: https://github.com/apache/doris/pull/69550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](fe) Separate filesystem routing validation and fallback hooks [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69550:
URL: https://github.com/apache/doris/pull/69550#issuecomment-6365894247

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org