You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Swatosh <jo...@gmail.com> on 2010/02/03 04:50:46 UTC

[patch] fix broken gen-make.py for windows

Mimic stsp's r905799 to get the build working again.

[[[

Follow-up to r905787:

* build/generator/gen_win.py
  (WinGeneratorBase._create_sqlite_headers): Track parameter list change for
   transform_sql.main().

]]]

Index: build/generator/gen_win.py
===================================================================
--- build/generator/gen_win.py  (revision 905882)
+++ build/generator/gen_win.py  (working copy)
@@ -1521,9 +1521,7 @@
       os.path.join('subversion', 'libsvn_wc', 'wc-checks'),
       ]
     for sql in sql_sources:
-      transform_sql.main(open(sql + '.sql', 'r'),
-                         open(sql + '.h', 'w'),
-                         os.path.basename(sql + '.sql'))
+      transform_sql.main(sql + '.sql', open(sql + '.h', 'w'))


 class ProjectItem:

Re: [patch] fix broken gen-make.py for windows

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Feb 02, 2010 at 08:50:46PM -0800, Joe Swatosh wrote:
> Mimic stsp's r905799 to get the build working again.

+1 to commit.

Thanks,
Stefan

> 
> [[[
> 
> Follow-up to r905787:
> 
> * build/generator/gen_win.py
>   (WinGeneratorBase._create_sqlite_headers): Track parameter list change for
>    transform_sql.main().
> 
> ]]]
> 
> Index: build/generator/gen_win.py
> ===================================================================
> --- build/generator/gen_win.py  (revision 905882)
> +++ build/generator/gen_win.py  (working copy)
> @@ -1521,9 +1521,7 @@
>        os.path.join('subversion', 'libsvn_wc', 'wc-checks'),
>        ]
>      for sql in sql_sources:
> -      transform_sql.main(open(sql + '.sql', 'r'),
> -                         open(sql + '.h', 'w'),
> -                         os.path.basename(sql + '.sql'))
> +      transform_sql.main(sql + '.sql', open(sql + '.h', 'w'))
> 
> 
>  class ProjectItem:

-- 
printf("Eh???/n");

Re: [patch] fix broken gen-make.py for windows

Posted by Greg Stein <gs...@gmail.com>.
committed in r906059. thanks!

On Tue, Feb 2, 2010 at 23:50, Joe Swatosh <jo...@gmail.com> wrote:
> Mimic stsp's r905799 to get the build working again.
>
> [[[
>
> Follow-up to r905787:
>
> * build/generator/gen_win.py
>  (WinGeneratorBase._create_sqlite_headers): Track parameter list change for
>   transform_sql.main().
>
> ]]]
>
> Index: build/generator/gen_win.py
> ===================================================================
> --- build/generator/gen_win.py  (revision 905882)
> +++ build/generator/gen_win.py  (working copy)
> @@ -1521,9 +1521,7 @@
>       os.path.join('subversion', 'libsvn_wc', 'wc-checks'),
>       ]
>     for sql in sql_sources:
> -      transform_sql.main(open(sql + '.sql', 'r'),
> -                         open(sql + '.h', 'w'),
> -                         os.path.basename(sql + '.sql'))
> +      transform_sql.main(sql + '.sql', open(sql + '.h', 'w'))
>
>
>  class ProjectItem:
>