You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2020/08/13 01:44:00 UTC
[jira] [Commented] (HBASE-24874) hbase-shell should not use
ModifiableTableDescriptor directly
[ https://issues.apache.org/jira/browse/HBASE-24874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176707#comment-17176707 ]
Duo Zhang commented on HBASE-24874:
-----------------------------------
We do not have UTs for this two commands? IIRC I did not see any failures on the hbase-shell UTs.
> hbase-shell should not use ModifiableTableDescriptor directly
> -------------------------------------------------------------
>
> Key: HBASE-24874
> URL: https://issues.apache.org/jira/browse/HBASE-24874
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 3.0.0-alpha-1
> Reporter: Elliot Miller
> Assignee: Elliot Miller
> Priority: Major
>
> HBASE-20819 prepared us for HBase 3.x by removing usages of the deprecated HTableDescriptor and HColumnDescriptor classes from the shell. However, it did use two methods from the ModifiableTableDescriptor, which was only public for compatibility/migration and was marked with {{@InterfaceAudience.Private}}. When {{ModifiableTableDescriptor}} was made private last week by HBASE-24507 it broke two hbase-shell commands (*describe* and *alter* when used to set a coprocessor) that were using methods from {{ModifiableTableDescriptor}} (these methods are not present on the general {{TableDescriptor}} interface).
> This story will remove the two references in hbase-shell to methods on the now-private {{ModifiableTableDescriptor}} class and will find appropriate replacements for the calls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)