You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/20 01:45:18 UTC

[GitHub] [spark] zhengruifeng commented on a diff in pull request #38310: [SPARK-40839][CONNECT][PYTHON] Implement `DataFrame.sample`

zhengruifeng commented on code in PR #38310:
URL: https://github.com/apache/spark/pull/38310#discussion_r1000065319


##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -201,6 +202,34 @@ def sort(self, *cols: "ColumnOrString") -> "DataFrame":
         """Sort by a specific column"""
         return DataFrame.withPlan(plan.Sort(self._plan, *cols), session=self._session)
 
+    def sample(

Review Comment:
   I guess we can discard those ones ? @HyukjinKwon 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org