You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2026/02/06 20:25:08 UTC
[PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
cstamas opened a new pull request, #11703:
URL: https://github.com/apache/maven/pull/11703
To run ITs w/ latest Eclipse Sisu 1.0.0-SNAPSHOT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #11703:
URL: https://github.com/apache/maven/pull/11703#discussion_r2779436322
##########
pom.xml:
##########
Review Comment:
There are quite some bugfixes listed in https://github.com/google/guice/wiki/Guice600#guice-core which potentially affect usage in Maven as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #11703:
URL: https://github.com/apache/maven/pull/11703#issuecomment-3884213322
Dependabot was faster, closing this out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #11703:
URL: https://github.com/apache/maven/pull/11703#discussion_r2777925544
##########
pom.xml:
##########
@@ -125,7 +125,7 @@ under the License.
<properties>
<javaVersion>8</javaVersion>
- <version.sisu-maven-plugin>0.9.0.M4</version.sisu-maven-plugin>
+ <version.sisu-maven-plugin>0.9.0-SNAPSHOT</version.sisu-maven-plugin>
Review Comment:
Sisu is still on version 0.0.9-SNAPSHOT (https://github.com/eclipse-sisu/sisu-project/blob/93c62c42396addd034b15eb35e289ba167c9bec3/pom.xml#L21), but semantically this is 1.0.0-SNAPSHOT (i.e. next release is 1.0.0 soon).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #11703:
URL: https://github.com/apache/maven/pull/11703#discussion_r2779522811
##########
pom.xml:
##########
Review Comment:
see some rationale behind downgrade here https://github.com/apache/maven/pull/2472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas closed pull request #11703: Eclipse Sisu 1.0.0-SNAPSHOT
URL: https://github.com/apache/maven/pull/11703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #11703:
URL: https://github.com/apache/maven/pull/11703#discussion_r2777723443
##########
pom.xml:
##########
@@ -125,7 +125,7 @@ under the License.
<properties>
<javaVersion>8</javaVersion>
- <version.sisu-maven-plugin>0.9.0.M4</version.sisu-maven-plugin>
+ <version.sisu-maven-plugin>0.9.0-SNAPSHOT</version.sisu-maven-plugin>
Review Comment:
Didn't you mention a 1.0.0(-SNAPSHOT) yesterday?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #11703:
URL: https://github.com/apache/maven/pull/11703#discussion_r2779191886
##########
pom.xml:
##########
Review Comment:
@cstamas Is Guice 6.0.0 not yet compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #11703:
URL: https://github.com/apache/maven/pull/11703#discussion_r2779524808
##########
pom.xml:
##########
@@ -125,7 +125,7 @@ under the License.
<properties>
<javaVersion>8</javaVersion>
- <version.sisu-maven-plugin>0.9.0.M4</version.sisu-maven-plugin>
+ <version.sisu-maven-plugin>0.9.0-SNAPSHOT</version.sisu-maven-plugin>
Review Comment:
looks like we have final version https://github.com/eclipse-sisu/sisu-project/releases/tag/releases%2F1.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Eclipse Sisu 1.0.0-SNAPSHOT [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #11703:
URL: https://github.com/apache/maven/pull/11703#discussion_r2779398978
##########
pom.xml:
##########
Review Comment:
Guice 6 is compatible, but users could assume we support jakarta inject as well, while Sisu is not. IMHO better like this: be clear about it, plus there is nothing we miss from guice 6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org