You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/27 17:02:39 UTC
[GitHub] [nifi] mattyb149 opened a new pull request #4020: NIFI-7054: Add
RecordSinkServiceLookup for dynamic sink routing
mattyb149 opened a new pull request #4020: NIFI-7054: Add RecordSinkServiceLookup for dynamic sink routing
URL: https://github.com/apache/nifi/pull/4020
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [x] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] YolandaMDavis commented on issue #4020: NIFI-7054: Add
RecordSinkServiceLookup for dynamic sink routing
Posted by GitBox <gi...@apache.org>.
YolandaMDavis commented on issue #4020: NIFI-7054: Add RecordSinkServiceLookup for dynamic sink routing
URL: https://github.com/apache/nifi/pull/4020#issuecomment-580066802
@mattyb149 I was able to test this by using a custom scripted processor which consumed records and sent them to the lookup service, using flow file attributes to store info for record.sink.name in each file. This worked well, however in looking at QueryNiFiReportingTask it doesn't seem as if it could leverage this as easily (because there is a discrete set of attributes that are sent to the sink from that task). I'm wondering if that can be enhanced in the context of this work as well to ensure that a record.sink.name can some how be propagated from that task?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] YolandaMDavis merged pull request #4020: NIFI-7054: Add
RecordSinkServiceLookup for dynamic sink routing
Posted by GitBox <gi...@apache.org>.
YolandaMDavis merged pull request #4020: NIFI-7054: Add RecordSinkServiceLookup for dynamic sink routing
URL: https://github.com/apache/nifi/pull/4020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] YolandaMDavis commented on issue #4020: NIFI-7054: Add
RecordSinkServiceLookup for dynamic sink routing
Posted by GitBox <gi...@apache.org>.
YolandaMDavis commented on issue #4020: NIFI-7054: Add RecordSinkServiceLookup for dynamic sink routing
URL: https://github.com/apache/nifi/pull/4020#issuecomment-581418526
@mattyb149 LGTM +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] YolandaMDavis commented on a change in pull request #4020:
NIFI-7054: Add RecordSinkServiceLookup for dynamic sink routing
Posted by GitBox <gi...@apache.org>.
YolandaMDavis commented on a change in pull request #4020: NIFI-7054: Add RecordSinkServiceLookup for dynamic sink routing
URL: https://github.com/apache/nifi/pull/4020#discussion_r372744657
##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-record-sink-service-bundle/nifi-record-sink-service/src/main/java/org/apache/nifi/record/sink/lookup/RecordSinkServiceLookup.java
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.record.sink.lookup;
+
+import org.apache.nifi.annotation.behavior.DynamicProperty;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.record.sink.RecordSinkService;
+import org.apache.nifi.serialization.WriteResult;
+import org.apache.nifi.serialization.record.RecordSet;
+import org.apache.nifi.service.lookup.AbstractSingleAttributeBasedControllerServiceLookup;
+
+import java.io.IOException;
+import java.util.Map;
+
+
+@Tags({"record", "sink", "lookup"})
+@CapabilityDescription("Provides a RecordSinkService that can be used to dynamically select another RecordSinkService. This service " +
+ "requires an attribute named 'record.sink.name' to be passed in when asking for a connection, and will throw an exception " +
+ "if the attribute is missing. The value of 'record.sink.name' will be used to select the RecordSinkService that has been " +
+ "registered with that name. This will allow multiple RecordSinkServices to be defined and registered, and then selected " +
+ "dynamically at runtime by tagging flow files with the appropriate 'record.sink.name' attribute.")
+@DynamicProperty(name = "The name to register the specified RecordSinkService", value = "The RecordSinkService",
+ description = "If '" + RecordSinkServiceLookup.RECORD_SINK_NAME_ATTRIBUTE + "' attribute contains " +
+ "the name of the dynamic property, then the RecordSinkService (registered in the value) will be selected.",
+ expressionLanguageScope = ExpressionLanguageScope.NONE)
+public class RecordSinkServiceLookup
+ extends AbstractSingleAttributeBasedControllerServiceLookup<RecordSinkService> implements RecordSinkService {
+
+ public static final String RECORD_SINK_NAME_ATTRIBUTE = "record.sink.name";
+
+ RecordSinkService recordSinkService;
+
+ @Override
+ protected String getLookupAttribute() {
+ return RECORD_SINK_NAME_ATTRIBUTE;
+ }
+
+ @Override
+ public Class<RecordSinkService> getServiceType() {
+ return RecordSinkService.class;
+ }
+
+ @Override
+ public WriteResult sendData(RecordSet recordSet, Map<String, String> attributes, boolean sendZeroResults) throws IOException {
+ try {
+ RecordSinkService recordSink = lookupService(attributes);
+ WriteResult writeResult = recordSink.sendData(recordSet, attributes, sendZeroResults);
+ if (recordSinkService == null) {
Review comment:
I think this only sets the recordSinkService variable once, however if the value changes, and if the reset is invoked, only the first used in the lookup service is reset. Should there be a way to ensure that all used values are reset when invoked? Or at least to ensure that the recordSinkService is changed when a different recordSink is retrieved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services