[jira] [Updated] (SOLR-8412) SchemaManager should synchronize on performOperations method

["Varun Thacker (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Varun Thacker updated SOLR-8412:
--------------------------------
    Attachment: SOLR-8412.patch

Patch which does 3 things

- synchronizes on {{performOperations}} instead of {{schema.getSchemaUpdateLock()}}
- Makes additional check of managed-schema being mutable
- Logging improvements

> SchemaManager should synchronize on performOperations method
> ------------------------------------------------------------
>
>                 Key: SOLR-8412
>                 URL: https://issues.apache.org/jira/browse/SOLR-8412
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Varun Thacker
>            Priority: Minor
>         Attachments: SOLR-8412.patch
>
>
> Currently SchemaManager synchronizes on {{schema.getSchemaUpdateLock()}} . We should synzhronize on {{performOperations}} instead. 
> The net affect will be the same but the code will be more clear. {{schema.getSchemaUpdateLock()}} is used when you want to edit a schema and add one field at a time. But the way SchemaManager works is that it does bulk operations i.e performs all operations and then persists the final schema . If there were two concurrent operations that took place, the later operation will retry by fetching the latest schema .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org