[jira] Commented: (JDO-621) Add javax.jdo.JDOEnhancerMain to call the enhancer via standard API

["Michael Bouschen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JDO-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754288#action_12754288 ] 

Michael Bouschen commented on JDO-621:
--------------------------------------

The patch looks good! 

Just two comments:
- Class javax.jdo.Enhancer implements the interface Constants in order to access the constants defines in the interface. I propose to consider a static import of the needed constants instead of implementing the interface. The same holds true for class MockEnhancer.
- I think the related issue JDO-591 can be set to resolved as soon as this issue is resolved.

> Add javax.jdo.JDOEnhancerMain to call the enhancer via standard API
> -------------------------------------------------------------------
>
>                 Key: JDO-621
>                 URL: https://issues.apache.org/jira/browse/JDO-621
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2
>    Affects Versions: JDO 2 maintenance release 2
>            Reporter: Craig Russell
>            Assignee: Craig Russell
>             Fix For: JDO 2 maintenance release 3
>
>         Attachments: jdo-621.patch
>
>
> The proposed new class will use the standard enhancer API to enhance classes. The command line parameters would be similar to the original proposal of JDO-591, with changes as needed to use the new class in the TCK.
> java -cp classpath {enhancer-class} [options] [jdo-files] [class-files] 
>     where options can be 
>         -persistenceUnit persistence-unit-name : Name of a "persistence-unit" to enhance the classes for 
>         -d target-dir-name : Write the enhanced classes to the specified directory 
>         -checkonly : Just check the classes for enhancement status 
>         -v : verbose output 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.