[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3015: ARTEMIS-2654 Improving Page cleanup and Operation Context

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #3015: ARTEMIS-2654 Improving Page cleanup and Operation Context
URL: https://github.com/apache/activemq-artemis/pull/3015#discussion_r391615802
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java
 ##########
 @@ -517,6 +528,23 @@ protected void cleanupComplete(ArrayList<PageSubscription> cursorList) throws Ex
 
       storeBookmark(cursorList, currentPage);
 
+      // notice this will be using the OperationContext started by cleanup
+      storageManager.afterCompleteOperations(new IOCallback() {
+         @Override
+         public void done() {
+
+            for (PageSubscription cursor : cursorList) {
+               cursor.enableAutoCleanup();
+            }
+         }
+
+         @Override
+         public void onError(int errorCode, String errorMessage) {
 
 Review comment:
   what about error handling?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services