You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Joerg Heinicke <jh...@virbus.de> on 2003/10/22 17:19:32 UTC

inheriting view declaration

Hello,

I'm trying to fix the consequences of my bugfix for 
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23949. One thing I came 
across is the often missing view declarations in the sitemaps that prevent 
viewing the source even for the sample sites (which did never use 
view-source.xsp). IIRC there was an agreement of inheriting view 
declarations. Is this correct? Is only the implementation missing?

Joerg

-- 
System Development
VIRBUS AG
Fon  +49(0)341-979-7419
Fax  +49(0)341-979-7409
joerg.heinicke@virbus.de
www.virbus.de


Re: inheriting view declaration

Posted by Joerg Heinicke <jh...@virbus.de>.
Carsten Ziegeler wrote:
> Sylvain Wallez wrote:
> 
>>>Afaik, implementing this should be very easy. I looked once at 
>>
>>it and I think it's only one method to change somewhere in the 
>>treeprocessor, but I don't remember it :(
>>
>>Ahem... AFAIK, implementing this is not trivial, as it's a case where 
>>pipeline building is split over several sitemaps. And this is not 
>>possible today, although blocks and virtual components will require it.
>>
>>Or did I miss something?
>>
> 
> Hmm, I thought there was one place where the view is looked up; 
> I thought of changing this that it also looks up in the parent
> sitemap etc. This should be easy I guess.
> When a view is a called the pipeline component is already instantiated
> and therefore it should be possible to add the components
> from the view to that object (transformer, serializer).
> A little bit more difficult might be the source resolving.
> Hmm, ok, perhaps you're right - but I think in 2.2 with
> the new environment handling it should be easy.
> 
> Carsten

Does not help me at the moment :-)

Added the views where missing and explicite sitemap matches for viewing 
resource sources. Hope I got all ...

Joerg

-- 
System Development
VIRBUS AG
Fon  +49(0)341-979-7419
Fax  +49(0)341-979-7409
joerg.heinicke@virbus.de
www.virbus.de


RE: inheriting view declaration

Posted by Carsten Ziegeler <cz...@s-und-n.de>.
Sylvain Wallez wrote:
> >
> >Afaik, implementing this should be very easy. I looked once at 
> it and I think it's only one method to change somewhere in the 
> treeprocessor, but I don't remember it :(
> >
> 
> Ahem... AFAIK, implementing this is not trivial, as it's a case where 
> pipeline building is split over several sitemaps. And this is not 
> possible today, although blocks and virtual components will require it.
> 
> Or did I miss something?
> 
Hmm, I thought there was one place where the view is looked up; 
I thought of changing this that it also looks up in the parent
sitemap etc. This should be easy I guess.
When a view is a called the pipeline component is already instantiated
and therefore it should be possible to add the components
from the view to that object (transformer, serializer).
A little bit more difficult might be the source resolving.
Hmm, ok, perhaps you're right - but I think in 2.2 with
the new environment handling it should be easy.

Carsten

Re: inheriting view declaration

Posted by Sylvain Wallez <sy...@anyware-tech.com>.
Carsten Ziegeler wrote:

>Joerg Heinicke wrote:
>  
>
>>Hello,
>>
>>I'm trying to fix the consequences of my bugfix for http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23949. One thing I came across is the often missing view declarations in the sitemaps that prevent viewing the source even for the sample sites (which did never use view-source.xsp). IIRC there was an agreement of inheriting view declarations. Is this correct? Is only the implementation missing?
>>    
>>
>Yepp!
>
>Afaik, implementing this should be very easy. I looked once at it and I think it's only one method to change somewhere in the treeprocessor, but I don't remember it :(
>

Ahem... AFAIK, implementing this is not trivial, as it's a case where 
pipeline building is split over several sitemaps. And this is not 
possible today, although blocks and virtual components will require it.

Or did I miss something?

Sylvain

-- 
Sylvain Wallez                                  Anyware Technologies
http://www.apache.org/~sylvain           http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
Orixo, the opensource XML business alliance  -  http://www.orixo.com



RE: inheriting view declaration

Posted by Carsten Ziegeler <cz...@s-und-n.de>.
Joerg Heinicke wrote:
>
>
> Hello,
>
> I'm trying to fix the consequences of my bugfix for
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23949. One thing I came
> across is the often missing view declarations in the sitemaps
> that prevent
> viewing the source even for the sample sites (which did never use
> view-source.xsp). IIRC there was an agreement of inheriting view
> declarations. Is this correct? Is only the implementation missing?
>
Yepp!

Afaik, implementing this should be very easy. I looked once at it
and I think it's only one method to change somewhere in the
treeprocessor, but I don't remember it :(

Carsten