You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/17 19:51:13 UTC
[GitHub] [spark] techaddict opened a new pull request, #39109: [SPARK-41430] Protobuf serializer for ProcessSummaryWrapper
techaddict opened a new pull request, #39109:
URL: https://github.com/apache/spark/pull/39109
### What changes were proposed in this pull request?
Add Protobuf serializer for ProcessSummaryWrapper
### Why are the changes needed?
Support fast and compact serialization/deserialization for ProcessSummaryWrapper over RocksDB.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
New UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #39109: [SPARK-41430][UI] Protobuf serializer for ProcessSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #39109:
URL: https://github.com/apache/spark/pull/39109#discussion_r1056042727
##########
core/src/test/scala/org/apache/spark/status/protobuf/KVStoreProtobufSerializerSuite.scala:
##########
@@ -523,4 +523,32 @@ class KVStoreProtobufSerializerSuite extends SparkFunSuite {
assert(result.info.numFailedTasks == input.info.numFailedTasks)
assert(result.info.numKilledTasks == input.info.numKilledTasks)
}
+
+ test("Process Summary") {
+ val input = new ProcessSummaryWrapper(
+ info = new ProcessSummary(
+ id = "id_1",
+ hostPort = "localhost:2020",
+ isActive = true,
+ totalCores = 4,
+ addTime = new Date(1234567L),
+ removeTime = Some(new Date(1234568L)),
+ processLogs = Map("log1" -> "log/log1", "log2" -> "logs/log2.log")
+ )
+ )
+ val bytes = serializer.serialize(input)
+ val result = serializer.deserialize(bytes, classOf[ProcessSummaryWrapper])
+ assert(result.info.id == input.info.id)
+ assert(result.info.hostPort == input.info.hostPort)
+ assert(result.info.isActive == input.info.isActive)
+ assert(result.info.totalCores == input.info.totalCores)
+ assert(result.info.addTime == input.info.addTime)
+ assert(result.info.removeTime == input.info.removeTime)
+ assert(result.info.processLogs.size == input.info.processLogs.size)
+ result.info.processLogs.keys.foreach { k =>
+ assert(result.info.processLogs.contains(k))
Review Comment:
I don't think we need this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #39109: [SPARK-41430][UI] Protobuf serializer for ProcessSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #39109: [SPARK-41430][UI] Protobuf serializer for ProcessSummaryWrapper
URL: https://github.com/apache/spark/pull/39109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #39109: [SPARK-41430][UI] Protobuf serializer for ProcessSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #39109:
URL: https://github.com/apache/spark/pull/39109#issuecomment-1363734116
@techaddict can you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] techaddict commented on pull request #39109: [SPARK-41430][UI] Protobuf serializer for ProcessSummaryWrapper
Posted by GitBox <gi...@apache.org>.
techaddict commented on PR #39109:
URL: https://github.com/apache/spark/pull/39109#issuecomment-1364178678
@gengliangwang merged, and build passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #39109: [SPARK-41430][UI] Protobuf serializer for ProcessSummaryWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #39109:
URL: https://github.com/apache/spark/pull/39109#issuecomment-1364413961
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org