You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org> on 2023/02/03 12:46:00 UTC
[GitHub] [airflow] Abhishek-kumar-samsung opened a new pull request, #29354: migrating from unittest to pytest tests cli file
Abhishek-kumar-samsung opened a new pull request, #29354:
URL: https://github.com/apache/airflow/pull/29354
I have migrated one test file from unittest to pytest. All test cases of this file are running normally as earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1415859429
@Taragolis Yes i will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1415824430
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1415856570
There is also one file exists in cli which use `parameterized.expand`:
https://github.com/apache/airflow/blob/ce677862be4a7de777208ba9ba9e62bcd0415393/tests/cli/commands/test_task_command.py#L337-L346
It would be nice to replace it by `@pytest.mark.parametrize` so we could complete CLI tests in one go.
This example could be helpful:
https://github.com/apache/airflow/blob/b4a7379763390a78eebf29dcaa33aa515b8d9468/tests/models/test_variable.py#L69-L72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1415939712
Let's wait till CI green.
I guess it will fail on static checks, i think you forgot to remove unused import.
General recommendation it is setup pre-commit, this step will save ton of your time, see [STATIC CHECKS](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#pre-commit-hooks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1416091739
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1415898255
@Taragolis complete the changes you said.
file running fine in which i did changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1416072056
@Taragolis
All removed unused dependencies, all checks are passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29354: migrating from unittest to pytest tests cli file
Posted by "Abhishek-kumar-samsung (via GitHub)" <gi...@apache.org>.
Abhishek-kumar-samsung commented on PR #29354:
URL: https://github.com/apache/airflow/pull/29354#issuecomment-1415945482
Okay, i will remove all unused imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis merged pull request #29354: migrating from unittest to pytest tests cli file
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #29354:
URL: https://github.com/apache/airflow/pull/29354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org