You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/01 04:21:28 UTC

[GitHub] [superset] codecov[bot] commented on pull request #13905: fix: consistent left margin for dashboard layout.

codecov[bot] commented on pull request #13905:
URL: https://github.com/apache/superset/pull/13905#issuecomment-811627095


   # [Codecov](https://codecov.io/gh/apache/superset/pull/13905?src=pr&el=h1) Report
   > Merging [#13905](https://codecov.io/gh/apache/superset/pull/13905?src=pr&el=desc) (4da64ce) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **increase** coverage by `0.11%`.
   > The diff coverage is `87.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/13905/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/13905?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #13905      +/-   ##
   ==========================================
   + Coverage   77.55%   77.67%   +0.11%     
   ==========================================
     Files         935      940       +5     
     Lines       47301    47563     +262     
     Branches     5907     5991      +84     
   ==========================================
   + Hits        36685    36944     +259     
   - Misses      10472    10476       +4     
   + Partials      144      143       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `64.35% <66.66%> (+0.62%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/13905?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...d/components/DashboardBuilder/DashboardBuilder.tsx](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEJ1aWxkZXIvRGFzaGJvYXJkQnVpbGRlci50c3g=) | `91.42% <87.50%> (-3.70%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Select.tsx](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1NlbGVjdC50c3g=) | `66.66% <0.00%> (-25.00%)` | :arrow_down: |
   | [...ntend/src/dashboard/components/dnd/handleScroll.ts](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVTY3JvbGwudHM=) | `38.46% <0.00%> (-8.21%)` | :arrow_down: |
   | [...ontend/src/explore/components/DataTableControl.tsx](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVDb250cm9sLnRzeA==) | `42.10% <0.00%> (-7.90%)` | :arrow_down: |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `61.84% <0.00%> (-5.27%)` | :arrow_down: |
   | [...frontend/src/explore/components/OptionControls.tsx](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9PcHRpb25Db250cm9scy50c3g=) | `64.77% <0.00%> (-2.25%)` | :arrow_down: |
   | [...frontend/src/components/DatabaseSelector/index.tsx](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci9pbmRleC50c3g=) | `90.29% <0.00%> (-1.38%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `62.44% <0.00%> (-0.09%)` | :arrow_down: |
   | [superset-frontend/src/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L2luZGV4LnRz) | `100.00% <0.00%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/superset/pull/13905/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13905?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13905?src=pr&el=footer). Last update [9d6832d...4da64ce](https://codecov.io/gh/apache/superset/pull/13905?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org