You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/24 01:55:27 UTC
[GitHub] [spark] gengliangwang opened a new pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
gengliangwang opened a new pull request #34088:
URL: https://github.com/apache/spark/pull/34088
…utors using config instead of command line"
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This reverts commit 866df69c6290b2f8e2726f1325969d23c938c0f2.
### Why are the changes needed?
After the change environment variables were not substituted in user classpath entries. Please find an example on SPARK-35672.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang edited a comment on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
gengliangwang edited a comment on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926285508
This is for branch-3.2 and branch-3.1
cc @peter-toth @tgravescs @xkrogen @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926349538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143579/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926314068
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926320732
for 3.1, I will directly revert https://github.com/apache/spark/commit/b4916d4a410820ba00125c00b55ca724b27cc853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926339514
**[Test build #143579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143579/testReport)** for PR 34088 at commit [`7816574`](https://github.com/apache/spark/commit/781657486e1952b9446201ae713d6fb8288bb9f8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926289733
**[Test build #143579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143579/testReport)** for PR 34088 at commit [`7816574`](https://github.com/apache/spark/commit/781657486e1952b9446201ae713d6fb8288bb9f8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926314083
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926319897
`UISeleniumSuite` test failure looks very unlikely related. I am merging it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926285508
This is for branch-3.2
cc @peter-toth @tgravescs @xkrogen @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926349538
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143579/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926301344
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34088:
URL: https://github.com/apache/spark/pull/34088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926289733
**[Test build #143579 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143579/testReport)** for PR 34088 at commit [`7816574`](https://github.com/apache/spark/commit/781657486e1952b9446201ae713d6fb8288bb9f8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34088: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to exec…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34088:
URL: https://github.com/apache/spark/pull/34088#issuecomment-926314083
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48088/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org