You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/04/23 07:02:15 UTC

[GitHub] [doris] yiguolei commented on a diff in pull request #18908: [improvement](profile) Insert into add LoadChannel runtime profile

yiguolei commented on code in PR #18908:
URL: https://github.com/apache/doris/pull/18908#discussion_r1174521569


##########
gensrc/proto/runtime_profile.proto:
##########
@@ -0,0 +1,78 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file

Review Comment:
   do not add such structure, just use profile's thrift structure and serialize it to bytes and send the binary data with protobuf message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org