You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Dmitry Irlyanov (JIRA)" <ji...@apache.org> on 2007/03/20 18:26:32 UTC
[jira] Created: (HARMONY-3448) Synth public classes are not
implemented
Synth public classes are not implemented
----------------------------------------
Key: HARMONY-3448
URL: https://issues.apache.org/jira/browse/HARMONY-3448
Project: Harmony
Issue Type: Sub-task
Components: Classlib
Reporter: Dmitry Irlyanov
Public classes provides base functionality for Synth.
All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483613 ]
Alexey Petrenko commented on HARMONY-3448:
------------------------------------------
Dmitry,
I've ran your patch through japitools and there are erros.
=== RI vs HARMONY ===
Missing
method javax.swing.plaf.synth.SynthLookAndFeel.getDisabledIcon(javax.swing.JComponent, javax.swing.Icon): missing in harmony.javax.swing.plaf.synth
method javax.swing.plaf.synth.SynthLookAndFeel.getDisabledSelectedIcon(javax.swing.JComponent, javax.swing.Icon): missing in harmony.javax.swing.plaf.synth
=== RI vs HARMONY ===
=== HARMONY vs RI ===
Bad
field javax.swing.plaf.synth.ColorType.MAX_COUNT: nonfinal in harmony.javax.swing.plaf.synth, but final in jdk15.javax.swing.plaf.synth
method javax.swing.plaf.synth.ColorType.getID(): nonfinal in harmony.javax.swing.plaf.synth, but final in jdk15.javax.swing.plaf.synth
Missing
field javax.swing.plaf.synth.Region.regionsMap: missing in jdk15.javax.swing.plaf.synth
field javax.swing.plaf.synth.SynthStyle.gUtils: missing in jdk15.javax.swing.plaf.synth
field javax.swing.plaf.synth.SynthStyle.insets: missing in jdk15.javax.swing.plaf.synth
field javax.swing.plaf.synth.SynthStyle.isOpaque: missing in jdk15.javax.swing.plaf.synth
field javax.swing.plaf.synth.SynthStyle.propertiesMap: missing in jdk15.javax.swing.plaf.synth
method javax.swing.plaf.synth.Region.getRegionFromName(java.lang.String): missing in jdk15.javax.swing.plaf.synth
method javax.swing.plaf.synth.SynthContext.gainState(int): missing in jdk15.javax.swing.plaf.synth
method javax.swing.plaf.synth.SynthContext.lossState(int): missing in jdk15.javax.swing.plaf.synth
method javax.swing.plaf.synth.SynthContext.setState(int): missing in jdk15.javax.swing.plaf.synth
method javax.swing.plaf.synth.SynthGraphicsUtils.computeFontMetrics(javax.swing.plaf.synth.SynthContext, java.awt.Font, java.awt.FontMetrics): missing in jdk15.javax.swing.plaf.synth
method javax.swing.plaf.synth.SynthGraphicsUtils.getFont(javax.swing.plaf.synth.SynthContext): missing in jdk15.javax.swing.plaf.synth
=== HARMONY vs RI ===
Could you please fix this errors.
Thanks in advance.
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3448) [classlib][swing] Synth public
classes are not implemented
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko resolved HARMONY-3448.
--------------------------------------
Resolution: Fixed
The patch has been applied. Please verify.
> [classlib][swing] Synth public classes are not implemented
> ----------------------------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-4.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch, H-3448-SynthStyleTest.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-3.patch
new version of patches attached
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) [classlib][swing] Synth public
classes are not implemented
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko updated HARMONY-3448:
-------------------------------------
Summary: [classlib][swing] Synth public classes are not implemented (was: Synth public classes are not implemented)
> [classlib][swing] Synth public classes are not implemented
> ----------------------------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-4.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-UnitTests-2.patch
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko reassigned HARMONY-3448:
----------------------------------------
Assignee: Alexey Petrenko
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-UnitTests.patch
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485156 ]
Alexey Petrenko commented on HARMONY-3448:
------------------------------------------
Dmitry,
you've introduced new japitools failure with the latest patch:
field javax.swing.plaf.synth.ColorType.count: missing in jdk15.javax.swing.plaf.synth
All other japitools issues seems to be fixed.
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-4.patch
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-4.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Comment: was deleted
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-3.patch
New versions for patches attached
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses.patch
The patch contains all the public synth classes. You can read about it in Java API or my javadoc.
The patch also adds 2 strings to be internationalized
The patch do not contains the unit tests for public synth classes
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Attachments: H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-UnitTests.patch
Unit tests
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486619 ]
Alexey Petrenko commented on HARMONY-3448:
------------------------------------------
Dmitry,
the last version of H-3448-SynthPublicClasses-3.patch can not be applied.
Patch fails with the following error message:
patch: **** malformed patch at line 1686: Index: src/main/java/common/javax/swing/plaf/synth/SynthContext.java
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487216 ]
Dmitry Irlyanov commented on HARMONY-3448:
------------------------------------------
Alexey,
Please use H-3448-SynthPublicClasses-4.patch I've verified it and all correct for me
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-4.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-3.patch
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) [classlib][swing] Synth public
classes are not implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthStyleTest.patch
Alexey,
My apologies, there is correct version of the test (H-3448-SynthStyleTest.patch).
> [classlib][swing] Synth public classes are not implemented
> ----------------------------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-4.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch, H-3448-SynthStyleTest.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3448) [classlib][swing] Synth public
classes are not implemented
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12490350 ]
Alexey Petrenko commented on HARMONY-3448:
------------------------------------------
Dima,
your latest patch with the tests can not be compiled. Here is the error message:
=== cut ===
[javac] 1. ERROR in C:\Users\cap\harmony\working_classlib\modules\swing\src\test\api\java\common\javax\swing\plaf\synth\SynthStyleTest.java
[javac] (at line 172)
[javac] propertiesMap.put(key, value);
[javac] ^^^^^^^^^^^^^
[javac] propertiesMap cannot be resolved
=== cut ===
I do not know how to resolve this issues so I did not commit this test. Please update it and I'll commit it later.
I've also did few modifications of your code. You can check "Subversion Commits" tub of the issue for modification details.
> [classlib][swing] Synth public classes are not implemented
> ----------------------------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-3.patch, H-3448-SynthPublicClasses-4.patch, H-3448-SynthPublicClasses-UnitTests-2.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses-UnitTests.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3448) Synth public classes are not
implemented
Posted by "Dmitry Irlyanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Irlyanov updated HARMONY-3448:
-------------------------------------
Attachment: H-3448-SynthPublicClasses-2.patch
Alexey,
Corrected patch attached.
Note that getDisabledIcon(javax.swing.JComponent, javax.swing.Icon) and getDisabledSelectedIcon(javax.swing.JComponent, javax.swing.Icon) methods are missed in parent class (LookAndFeel) and this is the only reason to japiTools failure in this methods.
> Synth public classes are not implemented
> ----------------------------------------
>
> Key: HARMONY-3448
> URL: https://issues.apache.org/jira/browse/HARMONY-3448
> Project: Harmony
> Issue Type: Sub-task
> Components: Classlib
> Reporter: Dmitry Irlyanov
> Assigned To: Alexey Petrenko
> Attachments: H-3448-SynthPublicClasses-2.patch, H-3448-SynthPublicClasses.patch
>
>
> Public classes provides base functionality for Synth.
> All the classes with unit tests should be implemented
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.