You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ch...@apache.org on 2004/12/27 18:44:06 UTC
svn commit: r123434 - /geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java /geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
Author: chirino
Date: Mon Dec 27 09:44:05 2004
New Revision: 123434
URL: http://svn.apache.org/viewcvs?view=rev&rev=123434
Log:
Modified:
geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java
geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
Modified: geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java
Url: http://svn.apache.org/viewcvs/geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java?view=diff&rev=123434&p1=geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java&r1=123433&p2=geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java&r2=123434
==============================================================================
--- geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java (original)
+++ geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java Mon Dec 27 09:44:05 2004
@@ -24,6 +24,7 @@
import org.activeio.AcceptListener;
import org.activeio.AsynchChannelServer;
import org.activeio.Channel;
+import org.activeio.Packet;
import org.activeio.RequestChannel;
import org.activeio.SynchChannel;
import org.activeio.SynchChannelServer;
@@ -100,9 +101,18 @@
}
private RequestChannel createRequestChannel(SynchChannel channel) throws IOException {
+
return new AsynchChannelToServerRequestChannel(
new PacketAggregatingAsynchChannel(
- new SynchToAsynchChannelAdapter(channel)));
+ new SynchToAsynchChannelAdapter(channel))) {
+ /**
+ * close out the channel once one request has been serviced.
+ */
+ public void onPacket(Packet packet) {
+ super.onPacket(packet);
+ dispose();
+ }
+ };
}
public void doStop() {
Modified: geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
Url: http://svn.apache.org/viewcvs/geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java?view=diff&rev=123434&p1=geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java&r1=123433&p2=geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java&r2=123434
==============================================================================
--- geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java (original)
+++ geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java Mon Dec 27 09:44:05 2004
@@ -35,10 +35,6 @@
private ClassLoader classloader;
private Interceptor next;
- public RequestChannelInterceptorInvoker(Interceptor next) {
- this.next = next;
- }
-
public RequestChannelInterceptorInvoker(Interceptor next, ClassLoader classloader) {
this.next = next;
this.classloader = classloader;
@@ -93,7 +89,7 @@
}
public void onRquestError(IOException error) {
- // TODO: handle this.
+ System.out.println("Request Error:"+error);
}
}
Re: svn commit: r123434 - /geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/JaasLoginServiceRemotingServer.java
/geronimo/trunk/modules/security/src/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
Posted by Jacek Laskowski <jl...@apache.org>.
chirino@apache.org wrote:
> Author: chirino
> Date: Mon Dec 27 09:44:05 2004
> New Revision: 123434
Hi,
I'm not happy to announce it, but there're two things I don't like about
this commit.
>
> URL: http://svn.apache.org/viewcvs?view=rev&rev=123434
> Log:
>
No Log included. To me, it's hardly known what the change is for.
> public void onRquestError(IOException error) {
..and the second is the name of the method - note the missing 'e'.
Don't get me wrong, but I think I'm not the one who teaches from you all
, so having seen no logs is what should be avoided.
Jacek