You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/10/09 01:41:18 UTC
Review Request 14547: FLUME-2208. Jetty's default SocketSelector leaks File
descriptors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14547/
-----------------------------------------------------------
Review request for Flume.
Bugs: FLUME-2208
https://issues.apache.org/jira/browse/FLUME-2208
Repository: flume-git
Description
-------
Use SelectChannelConnector instead of SocketChannelConnector fixes the issue
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 373e344
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java de79e8b
Diff: https://reviews.apache.org/r/14547/diff/
Testing
-------
All tests pass
Thanks,
Hari Shreedharan
Re: Review Request 14547: FLUME-2208. Jetty's default SocketSelector leaks
File descriptors
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14547/#review26809
-----------------------------------------------------------
+1 LGTM. I know this is an annoyance with the existing implementation. Test pass.
- Mike Percy
On Oct. 8, 2013, 11:41 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14547/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:41 p.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2208
> https://issues.apache.org/jira/browse/FLUME-2208
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Use SelectChannelConnector instead of SocketChannelConnector fixes the issue
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 373e344
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java de79e8b
>
> Diff: https://reviews.apache.org/r/14547/diff/
>
>
> Testing
> -------
>
> All tests pass
>
>
> Thanks,
>
> Hari Shreedharan
>
>