[jira] [Resolved] (REEF-1022) Replace $PackagesDir in EnsureNuGetPackageBuildImports

["Markus Weimer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/REEF-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus Weimer resolved REEF-1022.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.14

Resolved via [#686|https://github.com/apache/incubator-reef/pull/686]

> Replace $PackagesDir in EnsureNuGetPackageBuildImports
> ------------------------------------------------------
>
>                 Key: REEF-1022
>                 URL: https://issues.apache.org/jira/browse/REEF-1022
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF.NET
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>             Fix For: 0.14
>
>
> When building .Net solution with `msbuild.exe /t:Clean,Build`, the following errors occurs.
> {code}
> Org.Apache.REEF.Client.Tests\Org.Apache.REEF.Client.Tests.csproj(102,5): error : This project references NuGet package(s) that are missing ...lang\cs\\.nuget\packages\xunit.core.2.1.0\build\portable-net45+w
> in8+wp8+wpa81\xunit.core.props.
> {code}
> It is because the following task fails with the default `$PackagesDir` instead of the one in `build.props`. 
> {code}
>  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
>     <PropertyGroup>
>       <ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
>     </PropertyGroup>
>     <Error Condition="!Exists('$(PackagesDir)\xunit.core.2.1.0\build\portable-net45+win8+wp8+wpa81\xunit.core.props')" Text="$([System.String]::Format('$(ErrorText)', '$(PackagesDir)\xunit.core.2.1.0\build\portable-net45+win8+wp8+wpa81\xunit.core.props'))" />
>     <Error Condition="!Exists('$(PackagesDir)\xunit.runner.visualstudio.2.1.0\build\net20\xunit.runner.visualstudio.props')" Text="$([System.String]::Format('$(ErrorText)', '$(PackagesDir)\xunit.runner.visualstudio.2.1.0\build\net20\xunit.runner.visualstudio.props'))" />
>   </Target>
> {code}
> For this case, it seems to be inevitable due to `BeforeTargets="PrepareForBuild"`. We should use `$(SolutionDir)\packages` instead of the one declared in `build.props`.
> {code}
> - <Error Condition="!Exists('$(PackagesDir)\xunit...
> + <Error Condition="!Exists('$(SolutionDir)\packages\xunit...
> {code}
> I'll make a quick fix PR. Any comments are welcome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)