[jira] [Commented] (IGNITE-13614) Potential bugs after [ignite-12701].

["Ivan Daschinskiy (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-13614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219623#comment-17219623 ] 

Ivan Daschinskiy commented on IGNITE-13614:
-------------------------------------------

Also, there is a definitely potential NPE in  {{org.apache.ignite.internal.client.util.GridClientUtils#checkFeatureSupportedByCluster}}


{code:java}
for (GridClientNode node : nodes) {
    byte[] featuresAttrBytes = node.attribute(IgniteNodeAttributes.ATTR_IGNITE_FEATURES); // Can be null.

    if (!IgniteFeatures.nodeSupports(featuresAttrBytes, feature)) { // NPE here
        if (failIfUnsupportedFound) {
            throw new GridClientException("Failed to execute command: cluster contains node that " +
                "doesn't support feature [nodeId=" + node.nodeId() + ", feature=" + feature + ']');
        }
        else
            return node.nodeId();
    }
}
{code}


> Potential bugs after [ignite-12701].
> ------------------------------------
>
>                 Key: IGNITE-13614
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13614
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 2.8.1
>            Reporter: Stanilovsky Evgeny
>            Priority: Major
>
>  After [1] has been merged to master looks like there are a bit places without test coverage where unexpected behavior could fired. 
> 1. GridClientClusterStateRequestV2 - new client send this class into old server = deserialization problem.
> 2. GridClusterStateProcessor#hasInMemoryCache have no filter for sys-cache, thus "--force" option will always be demanded.
> [~vladsz83] [~nizhikov] take a look plz.
> [1] https://issues.apache.org/jira/browse/IGNITE-12701



--
This message was sent by Atlassian Jira
(v8.3.4#803005)