You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/17 20:02:46 UTC

[GitHub] [incubator-superset] betodealmeida commented on issue #8854: Add toast presenter to Welcome app

betodealmeida commented on issue #8854: Add toast presenter to Welcome app
URL: https://github.com/apache/incubator-superset/pull/8854#issuecomment-566726281
 
 
   > @khtruong: Based on your screenshot, does each "An error occurred" toast correspond to different errors or the same one?
   
   They're different errors: one of them comes from trying to load dashboards, the other 3 are from a generic component (`<TableLoader />`), so I left the error message as is. Do you think we should also catch 401s in the component and return a different error message if the user doesn't have authorization?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org