You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/14 03:18:14 UTC

[GitHub] [skywalking-rust] tisonkun edited a comment on pull request #9: gracefully shutdown reporter & add agent-test-tool based e2e case

tisonkun edited a comment on pull request #9:
URL: https://github.com/apache/skywalking-rust/pull/9#issuecomment-1012712902


   @wu-sheng I checked the report and don't think it's a real regression:
   
   1. "Regressions" on `impl fmt:Debug`. It's meaningless to test a standard lib implementation.
   2. "Regressions" on `shutdown`/`sender`.  The e2e test should cover it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org