[jira] [Created] (HDFS-16648) Normalize the usage of debug logs in NameNode

["ZanderXu (Jira)" <ji...@apache.org>]

ZanderXu created HDFS-16648:
-------------------------------

             Summary: Normalize the usage of debug logs in NameNode
                 Key: HDFS-16648
                 URL: https://issues.apache.org/jira/browse/HDFS-16648
             Project: Hadoop HDFS
          Issue Type: Improvement
            Reporter: ZanderXu
            Assignee: ZanderXu


There are many irregular debug logs in NameNode.  such as:
Error type1: 
{code:java}
if (LOG.isDebugEnabled()) {
      LOG.debug("Getting groups for user " + user);
}
{code}
we can format it to:
{code:java}
LOG.debug("Getting groups for user {}. ", user);
{code}

Error type2:
{code:java}
LOG.debug("*DIR* NameNode.renameSnapshot: Snapshot Path {}, " +
        "snapshotOldName {}, snapshotNewName {}", snapshotRoot,
        snapshotOldName, snapshotNewName);
{code}
we can format it to:
{code:java}
if (LOG.isDebugEnabled()) {
  LOG.debug("*DIR* NameNode.renameSnapshot: Snapshot Path {}, " +
        "snapshotOldName {}, snapshotNewName {}", snapshotRoot,
        snapshotOldName, snapshotNewName); 
}
{code}

Error type3:
{code:java}
if (LOG.isDebugEnabled()) {
      LOG.debug("getAdditionalDatanode: src=" + src
          + ", fileId=" + fileId
          + ", blk=" + blk
          + ", existings=" + Arrays.asList(existings)
          + ", excludes=" + Arrays.asList(excludes)
          + ", numAdditionalNodes=" + numAdditionalNodes
          + ", clientName=" + clientName);
    }
{code}
We can format it to:
{code:java}
 if (LOG.isDebugEnabled()) {
   LOG.debug("getAdditionalDatanode: src={}, fileId={}, "
           + "blk={}, existings={}, excludes={}, numAdditionalNodes={}, "
          + "clientName={}.", src, fileId, blk, Arrays.asList(existings),
          Arrays.asList(excludes), numAdditionalNodes, clientName);
 }
{code}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org