You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/02/01 12:44:33 UTC
DO NOT REPLY [Bug 50698] New: [PATCH] Synchronize access to
java.awt.ICC_Profile
https://issues.apache.org/bugzilla/show_bug.cgi?id=50698
Summary: [PATCH] Synchronize access to java.awt.ICC_Profile
Product: Fop
Version: 1.1dev
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: fop-dev@xmlgraphics.apache.org
ReportedBy: adelmelle@apache.org
Created an attachment (id=26588)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26588)
proposed patch addressing potential issue in FOP
In response to a recent post on fop-users@ (see:
http://marc.info/?l=fop-user&m=129646673801270&w=2), the attached patch:
- adds two methods to fop.util.ColorProfileUtil that perform calls to
ICC_Profile.getInstance() in a synchronized fashion (only the InputStream and
int variants are used)
- replaces all direct calls to ICC_Profile.getInstance() in FOP's code with
calls to one of those new methods
Note: The issue mentioned in the original post is *not* addressed by this
patch, as that instance of the issue arises somewhere in XMLGraphics.
Probably a good step to take towards solving this in XG, is to migrate the
ColorProfileUtil class there, and have FOP reference that one.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50698] [PATCH] Synchronize access to
java.awt.color.ICC_Profile
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50698
--- Comment #1 from Jeremias Maerki <je...@apache.org> 2011-02-01 07:19:08 EST ---
As you suggested, I'd move ColorProfileUtil over to XGC and apply the changes
for that class there. Batik suffers from the same problem apparently
(SVGColorProfileElementBridge). Thanks for looking into it. You actually beat
me to it. I wanted to do something similar.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50698] [PATCH] Synchronize access to
java.awt.color.ICC_Profile
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50698
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[PATCH] Synchronize access |[PATCH] Synchronize access
|to java.awt.ICC_Profile |to
| |java.awt.color.ICC_Profile
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50698] [PATCH] Synchronize access to
java.awt.color.ICC_Profile
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50698
Glenn Adams <gl...@skynav.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #3 from Glenn Adams <gl...@skynav.com> 2012-04-01 06:18:53 UTC ---
batch transition to closed; if someone wishes to restore one of these to
resolved in order to perform a verification step, then feel free to do so
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 50698] [PATCH] Synchronize access to
java.awt.color.ICC_Profile
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50698
Andreas L. Delmelle <ad...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #2 from Andreas L. Delmelle <ad...@apache.org> 2011-02-01 15:06:29 EST ---
Alternate approach taken as proposed. Changes to FOP committed in r1066182
(http://svn.apache.org/viewvc?rev=1066182&view=rev)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.