You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2022/07/08 08:51:32 UTC
[GitHub] [unomi] jkevan commented on a diff in pull request #458: UNOMI-626: improve migration system to prepare Unomi 2.0.0 data model
jkevan commented on code in PR #458:
URL: https://github.com/apache/unomi/pull/458#discussion_r916605652
##########
tools/shell-commands/src/main/java/org/apache/unomi/shell/migration/utils/MigrationUtils.java:
##########
@@ -44,4 +49,43 @@ public static JSONObject continueQueryWithScroll(CloseableHttpClient httpClient,
public static void bulkUpdate(CloseableHttpClient httpClient, String url, String jsonData) throws IOException {
HttpUtils.executePostRequest(httpClient, url, jsonData, null);
}
+
+ public static String resourceAsString(BundleContext bundleContext, final String resource) {
+ final URL url = bundleContext.getBundle().getResource(resource);
+ try (InputStream stream = url.openStream()) {
+ return IOUtils.toString(stream, StandardCharsets.UTF_8);
+ } catch (final Exception e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ public static void reIndex(CloseableHttpClient httpClient, BundleContext bundleContext, String esAddress, String indexName, String newIndexSettings) throws IOException {
+ String indexNameCloned = indexName + "-cloned";
+
+ // Init requests
+ JSONObject originalIndexSettings = new JSONObject(HttpUtils.executeGetRequest(httpClient, esAddress + "/" + indexName + "/_settings", null));
+ // TODO UNOMI-606 validate following lines: (normally those properties are automatically added to unomi indices so they should always be present on the existing indices)
+ String newIndexRequest = newIndexSettings
+ .replace("#numberOfShards", originalIndexSettings.getJSONObject(indexName).getJSONObject("settings").getJSONObject("index").getString("number_of_shards"))
+ .replace("#numberOfReplicas", originalIndexSettings.getJSONObject(indexName).getJSONObject("settings").getJSONObject("index").getString("number_of_replicas"))
+ .replace("#maxDocValueFieldsSearch", originalIndexSettings.getJSONObject(indexName).getJSONObject("settings").getJSONObject("index").getString("max_docvalue_fields_search"))
+ .replace("#mappingTotalFieldsLimit", originalIndexSettings.getJSONObject(indexName).getJSONObject("settings").getJSONObject("index").getJSONObject("mapping").getJSONObject("total_fields").getString("limit"));
+ String reIndexRequest = resourceAsString(bundleContext, "requestBody/2.0.0/base_reindex_request.json")
+ .replace("#source", indexNameCloned)
+ .replace("#dest", indexName);
+ String setIndexReadOnlyRequest = resourceAsString(bundleContext, "requestBody/2.0.0/base_set_index_readonly_request.json");
+
+ // Set original index as readOnly
+ HttpUtils.executePutRequest(httpClient, esAddress + "/" + indexName + "/_settings", setIndexReadOnlyRequest, null);
Review Comment:
Thx yes this part of the code will be finilized on the segment migration story.
##########
tools/shell-commands/src/main/java/org/apache/unomi/shell/migration/utils/MigrationUtils.java:
##########
@@ -44,4 +49,43 @@ public static JSONObject continueQueryWithScroll(CloseableHttpClient httpClient,
public static void bulkUpdate(CloseableHttpClient httpClient, String url, String jsonData) throws IOException {
HttpUtils.executePostRequest(httpClient, url, jsonData, null);
}
+
+ public static String resourceAsString(BundleContext bundleContext, final String resource) {
+ final URL url = bundleContext.getBundle().getResource(resource);
+ try (InputStream stream = url.openStream()) {
+ return IOUtils.toString(stream, StandardCharsets.UTF_8);
+ } catch (final Exception e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ public static void reIndex(CloseableHttpClient httpClient, BundleContext bundleContext, String esAddress, String indexName, String newIndexSettings) throws IOException {
+ String indexNameCloned = indexName + "-cloned";
+
+ // Init requests
+ JSONObject originalIndexSettings = new JSONObject(HttpUtils.executeGetRequest(httpClient, esAddress + "/" + indexName + "/_settings", null));
+ // TODO UNOMI-606 validate following lines: (normally those properties are automatically added to unomi indices so they should always be present on the existing indices)
+ String newIndexRequest = newIndexSettings
+ .replace("#numberOfShards", originalIndexSettings.getJSONObject(indexName).getJSONObject("settings").getJSONObject("index").getString("number_of_shards"))
Review Comment:
Thx yes this part of the code will be finilized on the segment migration story.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org