You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/12 12:40:45 UTC
[GitHub] [rocketmq] yuz10 opened a new pull request, #4157: add request fail reason
yuz10 opened a new pull request, #4157:
URL: https://github.com/apache/rocketmq/pull/4157
**Make sure set the target branch to `develop`**
## What is the purpose of the change
XXXXX
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4157: [ISSUE #4158] add request fail reason
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4157:
URL: https://github.com/apache/rocketmq/pull/4157#issuecomment-1097293844
[](https://coveralls.io/builds/48229525)
Coverage increased (+0.08%) to 52.048% when pulling **8c6eae24c85bde1a953999e0700f304f73e1cc89 on yuz10:develop3** into **ead6274b3e8016ee2fa75cf0dc201b5581ee7a34 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 commented on pull request #4157: [ISSUE #4158] add request fail reason
Posted by GitBox <gi...@apache.org>.
yuz10 commented on PR #4157:
URL: https://github.com/apache/rocketmq/pull/4157#issuecomment-1104652331
> I think the reason may be that the channel was closed before the pull message request was sent.
Yes, the exception occurs after shutdown a consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover commented on a diff in pull request #4157: [ISSUE #4158] add request fail reason
Posted by GitBox <gi...@apache.org>.
lwclover commented on code in PR #4157:
URL: https://github.com/apache/rocketmq/pull/4157#discussion_r849010724
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java:
##########
@@ -496,11 +497,12 @@ public void operationComplete(ChannelFuture f) throws Exception {
}
}
- private void requestFail(final int opaque) {
+ private void requestFail(final int opaque, Throwable cause) {
ResponseFuture responseFuture = responseTable.remove(opaque);
if (responseFuture != null) {
responseFuture.setSendRequestOK(false);
responseFuture.putResponse(null);
+ responseFuture.setCause(cause);
Review Comment:
I think we should add a nonnull judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover commented on pull request #4157: [ISSUE #4158] add request fail reason
Posted by GitBox <gi...@apache.org>.
lwclover commented on PR #4157:
URL: https://github.com/apache/rocketmq/pull/4157#issuecomment-1097483224
I think the reason may be that the channel was closed before the pull message request was sent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lwclover commented on a diff in pull request #4157: [ISSUE #4158] add request fail reason
Posted by GitBox <gi...@apache.org>.
lwclover commented on code in PR #4157:
URL: https://github.com/apache/rocketmq/pull/4157#discussion_r849011588
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java:
##########
@@ -522,7 +524,7 @@ protected void failFast(final Channel channel) {
if (entry.getValue().getProcessChannel() == channel) {
Integer opaque = entry.getKey();
if (opaque != null) {
- requestFail(opaque);
+ requestFail(opaque, new RemotingException("channel closed"));
Review Comment:
'failFast' method may be a right call, the second param is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 closed pull request #4157: [ISSUE #4158] add request fail reason
Posted by "yuz10 (via GitHub)" <gi...@apache.org>.
yuz10 closed pull request #4157: [ISSUE #4158] add request fail reason
URL: https://github.com/apache/rocketmq/pull/4157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org