[GitHub] [pulsar] heesung-sn commented on a diff in pull request #18877: [fix] [broker] getLastMessageId returns a wrong batch index of last message if enabled read compacted

["heesung-sn (via GitHub)" <gi...@apache.org>]

heesung-sn commented on code in PR #18877:
URL: https://github.com/apache/pulsar/pull/18877#discussion_r1165000498


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2017,6 +2027,25 @@ private void handleLastMessageIdFromCompactedLedger(PersistentTopic persistentTo
         });
     }
 
+    private int calculateTheLastBatchIndexInBatch(MessageMetadata metadata, ByteBuf payload) throws IOException {
+        int batchSize = metadata.getNumMessagesInBatch();
+        if (batchSize <= 1){
+            return -1;
+        }
+        SingleMessageMetadata singleMessageMetadata = new SingleMessageMetadata();
+        int lastBatchIndexInBatch = -1;
+        for (int i = 0; i < batchSize; i++){
+            ByteBuf singleMessagePayload =
+                    Commands.deSerializeSingleMessageInBatch(payload, singleMessageMetadata, i, batchSize);

Review Comment:
    @codelipenghui 
   
   I think this can error if the payload is compressed, encrypted, or both.
   
   Also, it would be insecure when decrypting customer data here if encrypted.
   
   Can we fix this issue by looking at the metadata only?
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org