You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Steven Phillips <sp...@maprtech.com> on 2014/05/29 12:38:49 UTC

Review Request 22018: DRILL-856: Reduce code-generation size for MergingReceiver

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22018/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

This patch gets rid of most of the code for generating the compare and copy methods in MergingReceiver, and instead wraps the incoming batches in a HyperBatch, and uses the normal code generation that deals with hyperbatches, as in Sort, etc.


Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingReceiverGeneratorBase.java 46a156f 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingReceiverTemplate.java 197e960 
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java 9101202 

Diff: https://reviews.apache.org/r/22018/diff/


Testing
-------


Thanks,

Steven Phillips