[GitHub] [ignite] nizhikov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework.

[GitBox <gi...@apache.org>]

nizhikov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework.
URL: https://github.com/apache/ignite/pull/6814#discussion_r323251743
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/util/nio/GridAbstractCommunicationClient.java
 ##########
 @@ -32,19 +39,27 @@
     /** Reservations. */
     private final AtomicBoolean closed = new AtomicBoolean();
 
-    /** Metrics listener. */
-    protected final GridNioMetricsListener metricsLsnr;
-
     /** */
     private final int connIdx;
 
+    /** Received bytes count metric. */
+    @Nullable protected final LongAdderMetric rcvdBytesCntMetric;
+
+    /** Sent bytes count metric. */
+    @Nullable protected final LongAdderMetric sentBytesCntMetric;
+
     /**
      * @param connIdx Connection index.
-     * @param metricsLsnr Metrics listener.
+     * @param mreg Metrics registry.
      */
-    protected GridAbstractCommunicationClient(int connIdx, @Nullable GridNioMetricsListener metricsLsnr) {
+    protected GridAbstractCommunicationClient(int connIdx, @Nullable MetricRegistry mreg) {
 
 Review comment:
   Why `mreg` can be null?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services