You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/04/26 22:02:57 UTC
[GitHub] [samza] cameronlee314 opened a new pull request #1493: SAMZA-2647: Clean up unused split deployment code
cameronlee314 opened a new pull request #1493:
URL: https://github.com/apache/samza/pull/1493
Issues: Some code was added for SEP-24 some time ago (https://github.com/apache/samza/pull/1172, https://github.com/apache/samza/pull/1173), but we are not moving forward with SEP-24 because it does not cleanly handle certain use cases. Since we don't need this code, it should get removed.
Changes:
1. Removed unused flows related to job coordinator dependency isolation.
2. Removed unused classloader separation utils.
Tests:
`./bin/integration-tests.sh /tmp/samza-tests yarn-integration-tests --nopassword` passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] cameronlee314 commented on pull request #1493: SAMZA-2647: Clean up unused split deployment code
Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on pull request #1493:
URL: https://github.com/apache/samza/pull/1493#issuecomment-828759493
> Looks good overall, I see in the testing section that you ran the yarn-integration tests, please ensure that still functional and up to date, I have personally never used it. I just deploy a samza-hello-samza app with a snapshot version.
>
> IIRC was the code not config controlled ? If yes please cleanup any relevant markdowns / docs
I think I did need to update a version locally for the integration tests, but they should otherwise be up to date. I would suggest trying them out, since then you don't need to manually verify anything as long as they report "success".
The code was config controlled by `job.split.deployment.enabled`, but since the impl wasn't completed, I don't think any docs had been modified to add that yet. I couldn't find any references to the config in the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] cameronlee314 merged pull request #1493: SAMZA-2647: Clean up unused split deployment code
Posted by GitBox <gi...@apache.org>.
cameronlee314 merged pull request #1493:
URL: https://github.com/apache/samza/pull/1493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org